Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: runtime/observatory/lib/src/elements/service_view.dart

Issue 1283413002: Fix table cpu profile to work properly with non-dart functions (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/service_view.dart
diff --git a/runtime/observatory/lib/src/elements/service_view.dart b/runtime/observatory/lib/src/elements/service_view.dart
index f0c20626b657ba9b892a48228cde9fa81da0d808..26ffd364a6d90ce02f35bf52d812e7df5f12e44f 100644
--- a/runtime/observatory/lib/src/elements/service_view.dart
+++ b/runtime/observatory/lib/src/elements/service_view.dart
@@ -78,25 +78,27 @@ class ServiceObjectViewElement extends ObservatoryElement {
element.connection = object;
return element;
case 'Object':
- switch (object.vmType) {
- case 'ICData':
- ICDataViewElement element = new Element.tag('icdata-view');
- element.icData = object;
- return element;
- case 'Instructions':
- InstructionsViewElement element =
- new Element.tag('instructions-view');
- element.instructions = object;
- return element;
- case 'ObjectPool':
- ObjectPoolViewElement element = new Element.tag('objectpool-view');
- element.pool = object;
- return element;
- default:
- ObjectViewElement element = new Element.tag('object-view');
- element.object = object;
- return element;
- }
+ return (object) {
Cutch 2015/08/13 13:43:13 Quiet the analyzer!
+ switch (object.vmType) {
+ case 'ICData':
+ ICDataViewElement element = new Element.tag('icdata-view');
+ element.icData = object;
+ return element;
+ case 'Instructions':
+ InstructionsViewElement element =
+ new Element.tag('instructions-view');
+ element.instructions = object;
+ return element;
+ case 'ObjectPool':
+ ObjectPoolViewElement element = new Element.tag('objectpool-view');
+ element.pool = object;
+ return element;
+ default:
+ ObjectViewElement element = new Element.tag('object-view');
+ element.object = object;
+ return element;
+ }
+ }(object);
case 'SocketList':
IOSocketListViewElement element =
new Element.tag('io-socket-list-view');

Powered by Google App Engine
This is Rietveld 408576698