Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: gpu/command_buffer/service/texture_manager.h

Issue 1283303002: gpu: FBO must be incomplete if the attached texture is not cube complete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Depend on https://codereview.chromium.org/1299683002 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/texture_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/texture_manager.h
diff --git a/gpu/command_buffer/service/texture_manager.h b/gpu/command_buffer/service/texture_manager.h
index b8b63c23a39f693cdc204a7362a0418cfa044921..9d1f49ef2ade333a3fceca27226755baf62a5ef3 100644
--- a/gpu/command_buffer/service/texture_manager.h
+++ b/gpu/command_buffer/service/texture_manager.h
@@ -102,6 +102,10 @@ class GPU_EXPORT Texture {
return estimated_size_;
}
+ // True if this texture meets all the GLES2 criteria for rendering.
+ // See section 3.7.10 of the GLES2 spec.
+ bool IsTextureComplete(const FeatureInfo* feature_info) const;
+
bool CanRenderTo() const {
return target_ != GL_TEXTURE_EXTERNAL_OES;
}
@@ -321,10 +325,6 @@ class GPU_EXPORT Texture {
return min_filter_ != GL_NEAREST && min_filter_ != GL_LINEAR;
}
- // True if this texture meets all the GLES2 criteria for rendering.
- // See section 3.7.10 of the GLES2 spec.
- bool IsTextureComplete(const FeatureInfo* feature_info) const;
-
// Returns true if mipmaps can be generated by GL.
bool CanGenerateMipmaps(const FeatureInfo* feature_info) const;
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/texture_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698