Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1283303002: gpu: FBO must be incomplete if the attached texture is not cube complete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Depend on https://codereview.chromium.org/1299683002 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.cc ('k') | gpu/command_buffer/service/texture_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 159928d7dded0eba9f1d81ccce75926be1137f42..44a9019580ec3fcea1644b1aa165968b1a3c50ca 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -3683,7 +3683,8 @@ bool GLES2DecoderImpl::CheckFramebufferValid(
return true;
}
- GLenum completeness = framebuffer->IsPossiblyComplete();
+ GLenum completeness =
+ framebuffer->IsPossiblyComplete(target, feature_info_.get());
if (completeness != GL_FRAMEBUFFER_COMPLETE) {
LOCAL_SET_GL_ERROR(
GL_INVALID_FRAMEBUFFER_OPERATION, func_name, "framebuffer incomplete");
@@ -5806,7 +5807,8 @@ GLenum GLES2DecoderImpl::DoCheckFramebufferStatus(GLenum target) {
if (!framebuffer) {
return GL_FRAMEBUFFER_COMPLETE;
}
- GLenum completeness = framebuffer->IsPossiblyComplete();
+ GLenum completeness =
+ framebuffer->IsPossiblyComplete(target, feature_info_.get());
if (completeness != GL_FRAMEBUFFER_COMPLETE) {
return completeness;
}
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.cc ('k') | gpu/command_buffer/service/texture_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698