Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.h

Issue 1283303002: gpu: FBO must be incomplete if the attached texture is not cube complete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Depend on https://codereview.chromium.org/1299683002 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/framebuffer_manager.h
diff --git a/gpu/command_buffer/service/framebuffer_manager.h b/gpu/command_buffer/service/framebuffer_manager.h
index 9bf440a17d03b18bd3491e859bd90c93f7108c0f..eba5f9003e6378e1690716268eb5d3ebe0fec841 100644
--- a/gpu/command_buffer/service/framebuffer_manager.h
+++ b/gpu/command_buffer/service/framebuffer_manager.h
@@ -44,6 +44,7 @@ class GPU_EXPORT Framebuffer : public base::RefCounted<Framebuffer> {
virtual bool IsTexture(TextureRef* texture) const = 0;
virtual bool IsRenderbuffer(
Renderbuffer* renderbuffer) const = 0;
+ virtual bool IsAttachmentComplete(FeatureInfo* feature_info) const = 0;
virtual bool CanRenderTo() const = 0;
virtual void DetachFromFramebuffer(Framebuffer* framebuffer) const = 0;
virtual bool ValidForAttachmentType(
@@ -129,7 +130,7 @@ class GPU_EXPORT Framebuffer : public base::RefCounted<Framebuffer> {
// Note that receiving GL_FRAMEBUFFER_COMPLETE from this function does
// not mean the real OpenGL will consider it framebuffer complete. It just
// means it passed our tests.
- GLenum IsPossiblyComplete() const;
+ GLenum IsPossiblyComplete(GLenum target, FeatureInfo* feature_info) const;
// Implements optimized glGetFramebufferStatus.
GLenum GetStatus(TextureManager* texture_manager, GLenum target) const;
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698