Issue 12833010: Revert 188113 "Revert 188080 "Add vm672-m1 (the new Mac ASan bui..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12833010: Revert 188113 "Revert 188080 "Add vm672-m1 (the new Mac ASan bui..." (Closed)

Created:
7 years, 9 months ago by Tyler Breisacher (Chromium)

Modified:
7 years, 9 months ago

Reviewers:
_com_google_glider, Tyler Breisacher (Chromium)

CC:
chromium-reviews, eugenis+clang_chromium.org, dmikurube+clang_chromium.org, glider+clang_chromium.org, glotov+watch_chromium.org, ukai+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 188113 "Revert 188080 "Add vm672-m1 (the new Mac ASan bui..." > Revert 188080 "Add vm672-m1 (the new Mac ASan builder) to the li..." > > This CL seems to be causing content_unittests flakiness on MAC ASAN Tests (1): http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%20Tests%20%281%29/builds/7515/steps/content_unittests/logs/stdio > > > Add vm672-m1 (the new Mac ASan builder) to the list of machines using pinned Clang version. > > > > BUG=170629 > > TBR=thakis > > Review URL: https://codereview.chromium.org/12729006 > > TBR=glider@chromium.org > Review URL: https://codereview.chromium.org/12545038 TBR=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188142

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	tools/clang/scripts/update.sh	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tyler Breisacher (Chromium)

Committed patchset #1 manually as r188142.

7 years, 9 months ago (2013-03-14 18:26:29 UTC) #2

_com_google_glider

7 years, 9 months ago (2013-03-14 19:27:14 UTC) #3

LGTM

On Thu, Mar 14, 2013 at 10:26 PM,  <tbreisacher@chromium.org> wrote:
> Committed patchset #1 manually as r188142.
>
> https://codereview.chromium.org/12833010/



--
Alexander Potapenko
Software Engineer
Google Moscow

Expand Messages | Collapse Messages