Revert 188080 "Add vm672-m1 (the new Mac ASan builder) to the li..."

Revert 188080 "Add vm672-m1 (the new Mac ASan builder) to the li..."

This CL seems to be causing content_unittests flakiness on MAC ASAN Tests (1): http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%20Tests%20%281%29/builds/7515/steps/content_unittests/logs/stdio

> Add vm672-m1 (the new Mac ASan builder) to the list of machines using pinned Clang version.
> 
> BUG=170629
> TBR=thakis
> Review URL: https://codereview.chromium.org/12729006

TBR=glider@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188113

[Tyler Breisacher (Chromium), 2013-03-14 17:31:31]

Committed patchset #1 manually as r188113.

[Alexander Potapenko, 2013-03-14 18:22:01]

Please no. This is gonna break compilation on the Mac ASan builder.
Moreover, the CL is unrelated to the tests' flakiness.
I'm going to address this when I get to ssh (hopefully within a hour). The
correct workaround involves restarting the memory master to switch the bots
back to 10.6
On Mar 14, 2013 9:27 PM, <tbreisacher@chromium.org> wrote:

> Reviewers: Alexander Potapenko,
>
> Description:
> Revert 188080 "Add vm672-m1 (the new Mac ASan builder) to the li..."
>
> R=stevet@chromium.org
>
>  Add vm672-m1 (the new Mac ASan builder) to the list of machines using
>> pinned
>>
> Clang version.
>
>  BUG=170629
>> TBR=thakis
>> Review URL:
https://codereview.chromium.**org/12729006<https://codereview.chromium.org/12...
>>
>
> TBR=glider@chromium.org
>
> Please review this at
https://codereview.chromium.**org/12545038/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   M     tools/clang/scripts/update.sh
>
>
> Index: tools/clang/scripts/update.sh
> ==============================**==============================**=======
> --- tools/clang/scripts/update.sh       (revision 188110)
> +++ tools/clang/scripts/update.sh       (working copy)
> @@ -91,14 +91,10 @@
>      return 1
>    fi
>    HOST="$(hostname -s)"
> -  # Old (10.6) Chrome Mac ASan Builder. Kept here till we fully migrate
> to 10.8
> +  # Chrome Mac ASan Builder.
>    if [[ "${HOST}" == "vm633-m1" ]]; then
>      return 0
>    fi
> -  # 10.8 Chrome Mac ASan Builder.
> -  if [[ "${HOST}" == "vm672-m1" ]]; then
> -    return 0
> -  fi
>    # Chrome Mac ASan LKGR.
>    if [[ "${HOST}" == "mini11-a1" ]]; then
>      return 0
>
>
>

[Tyler Breisacher (Chromium), 2013-03-14 18:23:40]

Ack, sorry, already landed. Should we re-land your original CL?

[Tyler Breisacher (Chromium), 2013-03-14 18:28:07]

On 2013/03/14 18:23:40, Tyler Breisacher (Chromium) wrote:
> Ack, sorry, already landed. Should we re-land your original CL?

Rolled back the rollback in https://codereview.chromium.org/12833010/ -- I won't
do anything else on this until I hear from you. Sorry for messing everything up.