Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 1283273002: Service Worker: Change last update check location and HTTP cache bypass rule (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index d4cee3793c4088f47a675bba31d73332c1452296..e6cf5d4aca803254ef536817cdc97ed6bc44862c 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -536,6 +536,8 @@ ServiceWorkerVersion::ServiceWorkerVersion(
scope_(registration->pattern()),
context_(context),
script_cache_map_(this, context),
+ max_age_(base::TimeDelta::FromSeconds(
+ kServiceWorkerScriptMaxCacheAgeInSeconds)),
ping_controller_(new PingController(this)),
weak_factory_(this) {
DCHECK(context_);
@@ -2215,8 +2217,7 @@ void ServiceWorkerVersion::MarkIfStale() {
return;
base::TimeDelta time_since_last_check =
base::Time::Now() - registration->last_update_check();
- if (time_since_last_check >
- base::TimeDelta::FromHours(kServiceWorkerScriptMaxCacheAgeInHours))
+ if (time_since_last_check > max_age())
jungkees 2015/08/20 01:52:56 I think this line of codes seems still need the co
RestartTick(&stale_time_);
}

Powered by Google App Engine
This is Rietveld 408576698