content/browser/service_worker/service_worker_write_to_cache_job.cc - Issue 1283273002: Service Worker: Change last update check location and HTTP cache bypass rule (2/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job.cc

Issue 1283273002: Service Worker: Change last update check location and HTTP cache bypass rule (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/browser/service_worker/service_worker_version.cc ('k') | content/common/service_worker/service_worker_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_write_to_cache_job.cc

diff --git a/content/browser/service_worker/service_worker_write_to_cache_job.cc b/content/browser/service_worker/service_worker_write_to_cache_job.cc

index 781a65257b61f1371eb8eaa703cdae73565c3dd0..1a0b9d064613f45f1e066f485409f6f87aad7f8a 100644

--- a/content/browser/service_worker/service_worker_write_to_cache_job.cc

+++ b/content/browser/service_worker/service_worker_write_to_cache_job.cc

@@ -669,6 +669,13 @@ void ServiceWorkerWriteToCacheJob::OnResponseStarted(

if (!CheckPathRestriction(request))

return;

+ const net::HttpResponseHeaders* headers = request->response_headers();

+ base::TimeDelta result;

+ if (headers->GetMaxAgeValue(&result) &&

+ result < base::TimeDelta::FromSeconds(

+ kServiceWorkerScriptMaxCacheAgeInSeconds))

+ version_->set_max_age(result);

version_->SetMainScriptHttpResponseInfo(net_request_->response_info());

}