Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 1283193002: Clear the selection and insertion flags only upon getting the selection event (Closed)

Created:
5 years, 4 months ago by raghu
Modified:
5 years, 4 months ago
Reviewers:
jdduke (slow), AKV
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear the selection and insertion flags only upon getting the selection event The mHasSelection and mHasInsertion flags are being cleared even before the selection events are received and hence the popup is never hidden. dismissTextHandles already triggers the selection events to clear the handles. Hence we dont need to clear them outside the selection event handler. BUG=520060 Committed: https://crrev.com/0f7316c4d8eeb601502549f7890aa8f34a873875 Cr-Commit-Position: refs/heads/master@{#343212}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added more test code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 chunks +2 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 2 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
AKV
minor change pointed. https://codereview.chromium.org/1283193002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/1283193002/diff/1/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode944 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:944: setComposingText("h", 1); It would be good ...
5 years, 4 months ago (2015-08-12 13:44:43 UTC) #2
AKV
peer review looks good to me!
5 years, 4 months ago (2015-08-13 05:50:56 UTC) #3
raghu
jdduke@, PTAL
5 years, 4 months ago (2015-08-13 05:56:42 UTC) #5
jdduke (slow)
lgtm, thanks.
5 years, 4 months ago (2015-08-13 15:24:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283193002/20001
5 years, 4 months ago (2015-08-13 15:24:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-13 16:32:24 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 16:33:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f7316c4d8eeb601502549f7890aa8f34a873875
Cr-Commit-Position: refs/heads/master@{#343212}

Powered by Google App Engine
This is Rietveld 408576698