Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1283193002: Clear the selection and insertion flags only upon getting the selection event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added more test code Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 60db709fdf5980974ea172e8721c994d08c8b0ac..a380c07cf2bc12de55c247cb8c7248dd3df048f4 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -2192,11 +2192,11 @@ public class ContentViewCore implements
return mHasSelection;
}
- /**
+ /**
* @return Whether the page has an active, touch-controlled insertion handle.
*/
@VisibleForTesting
- protected boolean hasInsertion() {
+ public boolean hasInsertion() {
return mHasInsertion;
}
@@ -2283,8 +2283,6 @@ public class ContentViewCore implements
}
private void dismissTextHandles() {
- mHasSelection = false;
- mHasInsertion = false;
if (mNativeContentViewCore != 0) nativeDismissTextHandles(mNativeContentViewCore);
}
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698