Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1283183002: Realize IWYU pattern for frames-inl.h header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Realize IWYU pattern for frames-inl.h header. R=bmeurer@chromium.org Committed: https://crrev.com/19a49abf02dfac722dc8c5079aba9d73fcd60725 Cr-Commit-Position: refs/heads/master@{#30127}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -11 lines) Patch
M src/arm/code-stubs-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/arm64/debug-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/debug.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/debug-frames.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/debug/debug-scopes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/ia32/debug-ia32.cc View 1 chunk +1 line, -1 line 2 comments Download
M src/debug/liveedit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/x87/debug-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/code-stubs-mips.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/ppc/code-stubs-ppc.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ppc/regexp-macro-assembler-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-liveedit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/safepoint-table.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-deopt.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
Note that the actual change is in src/debug/debug.h, which brings us down to 6 violations ...
5 years, 4 months ago (2015-08-12 09:16:03 UTC) #1
Yang
https://codereview.chromium.org/1283183002/diff/1/src/debug/ia32/debug-ia32.cc File src/debug/ia32/debug-ia32.cc (right): https://codereview.chromium.org/1283183002/diff/1/src/debug/ia32/debug-ia32.cc#newcode11 src/debug/ia32/debug-ia32.cc:11: #include "src/ia32/frames-ia32.h" A bit surprised that debug-x64.cc doesn't need ...
5 years, 4 months ago (2015-08-12 09:46:17 UTC) #3
Michael Starzinger
https://codereview.chromium.org/1283183002/diff/1/src/debug/ia32/debug-ia32.cc File src/debug/ia32/debug-ia32.cc (right): https://codereview.chromium.org/1283183002/diff/1/src/debug/ia32/debug-ia32.cc#newcode11 src/debug/ia32/debug-ia32.cc:11: #include "src/ia32/frames-ia32.h" On 2015/08/12 09:46:17, Yang wrote: > A ...
5 years, 4 months ago (2015-08-12 09:54:16 UTC) #4
Benedikt Meurer
LGTM from my side.
5 years, 4 months ago (2015-08-12 10:24:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283183002/1
5 years, 4 months ago (2015-08-12 10:26:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 10:28:41 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 10:29:00 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/19a49abf02dfac722dc8c5079aba9d73fcd60725
Cr-Commit-Position: refs/heads/master@{#30127}

Powered by Google App Engine
This is Rietveld 408576698