Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1283023002: Remove grab-bag includes of v8.h from debugger. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-fullcode
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove grab-bag includes of v8.h from debugger. R=yangguo@chromium.org Committed: https://crrev.com/6690d4704575d0c4b8f14e6d8b32a1e289cd3363 Cr-Commit-Position: refs/heads/master@{#30131}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M src/debug/arm/debug-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug/arm64/debug-arm64.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug/debug.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug/ia32/debug-ia32.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug/liveedit.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M src/debug/mips/debug-mips.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/debug/mips64/debug-mips64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/debug/ppc/debug-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug/x64/debug-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug/x87/debug-x87.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-11 13:20:02 UTC) #1
Yang
On 2015/08/11 13:20:02, Michael Starzinger wrote: lgtm.
5 years, 4 months ago (2015-08-12 10:25:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283023002/20001
5 years, 4 months ago (2015-08-12 10:35:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 11:14:07 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 11:14:22 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6690d4704575d0c4b8f14e6d8b32a1e289cd3363
Cr-Commit-Position: refs/heads/master@{#30131}

Powered by Google App Engine
This is Rietveld 408576698