Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1282763002: [turbofan] Drop V8_TURBOFAN_BACKEND and V8_TURBOFAN_TARGET defines. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Drop V8_TURBOFAN_BACKEND and V8_TURBOFAN_TARGET defines. TurboFan is now a requirement and supported by all backends, so we don't need those macros (plus all the machinery on top) anymore. R=jarin@chromium.org Committed: https://crrev.com/6db78c8065855a1ffb3cfbf79406f51d1163102e Cr-Commit-Position: refs/heads/master@{#30082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -382 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M src/compiler/instruction-selector.cc View 4 chunks +2 lines, -42 lines 0 comments Download
M src/compiler/pipeline.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -23 lines 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 4 chunks +0 lines, -17 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-basic-block-profiler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 8 chunks +6 lines, -117 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-run-deopt.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 39 chunks +6 lines, -60 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/unittests/compiler/compiler-test-utils.h View 1 chunk +0 lines, -16 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 4 months ago (2015-08-10 06:52:07 UTC) #1
Benedikt Meurer
Hey Jaro, As per email discussion, remove the obsolete macros. Please take a look. Thanks, ...
5 years, 4 months ago (2015-08-10 06:52:40 UTC) #2
Jarin
lgtm
5 years, 4 months ago (2015-08-10 06:54:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282763002/1
5 years, 4 months ago (2015-08-10 06:54:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 07:17:21 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 07:17:46 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6db78c8065855a1ffb3cfbf79406f51d1163102e
Cr-Commit-Position: refs/heads/master@{#30082}

Powered by Google App Engine
This is Rietveld 408576698