Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: src/pathops/SkPathOpsPoint.cpp

Issue 12827020: Add base types for path ops (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/pathops/SkPathOpsPoint.cpp
===================================================================
--- src/pathops/SkPathOpsPoint.cpp (revision 0)
+++ src/pathops/SkPathOpsPoint.cpp (revision 0)
@@ -0,0 +1,17 @@
+/*
+ * Copyright 2012 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+#include "SkPathOpsPoint.h"
+
+SkDVector operator-(const SkDPoint& a, const SkDPoint& b) {
whunt 2013/03/22 18:16:06 This function should be inlined. If the rational
caryclark 2013/03/22 19:38:51 Again, I think measurement is the key. The compile
+ SkDVector v = {a.fX - b.fX, a.fY - b.fY};
whunt 2013/03/22 18:16:06 you'll bet better code with a constructor
caryclark 2013/03/22 19:38:51 As Mike has pointed out, Skia intentionally does n
+ return v;
+}
+
+SkDPoint operator+(const SkDPoint& a, const SkDVector& b) {
whunt 2013/03/22 18:16:06 This function should be inlined. If the rational
caryclark 2013/03/22 20:05:00 Noted.
+ SkDPoint v = {a.fX + b.fX, a.fY + b.fY};
whunt 2013/03/22 18:16:06 you'll bet better code with a constructor
caryclark 2013/03/22 20:05:00 Noted.
+ return v;
+}

Powered by Google App Engine
This is Rietveld 408576698