Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: src/pathops/SkPathOpsPoint.cpp

Issue 12827020: Add base types for path ops (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 /*
2 * Copyright 2012 Google Inc.
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7 #include "SkPathOpsPoint.h"
8
9 SkDVector operator-(const SkDPoint& a, const SkDPoint& b) {
whunt 2013/03/22 18:16:06 This function should be inlined. If the rational
caryclark 2013/03/22 19:38:51 Again, I think measurement is the key. The compile
10 SkDVector v = {a.fX - b.fX, a.fY - b.fY};
whunt 2013/03/22 18:16:06 you'll bet better code with a constructor
caryclark 2013/03/22 19:38:51 As Mike has pointed out, Skia intentionally does n
11 return v;
12 }
13
14 SkDPoint operator+(const SkDPoint& a, const SkDVector& b) {
whunt 2013/03/22 18:16:06 This function should be inlined. If the rational
caryclark 2013/03/22 20:05:00 Noted.
15 SkDPoint v = {a.fX + b.fX, a.fY + b.fY};
whunt 2013/03/22 18:16:06 you'll bet better code with a constructor
caryclark 2013/03/22 20:05:00 Noted.
16 return v;
17 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698