Issue 12826: RegExp stack and zone limits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12826: RegExp stack and zone limits. (Closed)

Created:
12 years ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Added checking in the regular expression parser that we're below the stack limit and that the zone allocation limit hasn't been met.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -51 lines)			Patch
M	src/parser.cc	View	29 chunks	+60 lines, -45 lines	2 comments	Download
M	src/top.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/top.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/zone.h	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	src/zone.cc	View	5 chunks	+12 lines, -3 lines	0 comments	Download
M	src/zone-inl.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View	4 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/12826/diff/1/2 File src/parser.cc (right): http://codereview.chromium.org/12826/diff/1/2#newcode1033 Line 1033: ((void)0 Maybe we should add a dummy ...

12 years ago (2008-12-01 15:29:09 UTC) #2

Christian Plesner Hansen

12 years ago (2008-12-01 15:52:55 UTC) #3

http://codereview.chromium.org/12826/diff/1/2
File src/parser.cc (right):

http://codereview.chromium.org/12826/diff/1/2#newcode1033
Line 1033: ((void)0
Aah, so that's what DUMMY was for.

Expand Messages | Collapse Messages