Issue 1282443002: Fix WebRemoteFrame leak in DetachRemoteFrame unit test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1282443002: Fix WebRemoteFrame leak in DetachRemoteFrame unit test. (Closed)

Created:
5 years, 4 months ago by sof

Modified:
5 years, 4 months ago

Reviewers:
haraken

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix WebRemoteFrame leak in DetachRemoteFrame unit test. TBR=haraken BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200160

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	Source/web/tests/WebFrameTest.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

TBRing this unit test leak fix so as to allow https://codereview.chromium.org/1275863002/ to be attempted landed.

5 years, 4 months ago (2015-08-07 12:02:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282443002/1

5 years, 4 months ago (2015-08-07 12:02:58 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200160

5 years, 4 months ago (2015-08-07 12:05:51 UTC) #6

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages