Source/web/tests/WebFrameTest.cpp - Issue 1282443002: Fix WebRemoteFrame leak in DetachRemoteFrame unit test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 1282443002: Fix WebRemoteFrame leak in DetachRemoteFrame unit test. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 89296919c35920bda368b105adfa8ba7f5049dfb..dd42a6b46f0adc6057d18e209257ed0dc95ab447 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -7599,6 +7599,7 @@ TEST_P(ParameterizedWebFrameTest, DetachRemoteFrame)

WebRemoteFrame* childFrame = view->mainFrame()->toWebRemoteFrame()->createRemoteChild(WebTreeScopeType::Document, "", WebSandboxFlags::None, &childFrameClient);

childFrame->detach();

view->close();

+ childFrame->close();

}

class TestConsoleMessageWebFrameClient : public FrameTestHelpers::TestWebFrameClient {

« no previous file with comments | « no previous file | no next file » | no next file with comments »