Restrict chrome.runtime.setUninstallURL to http(s)

Restrict chrome.runtime.setUninstallURL to http(s)

Disallow URLs other than http(s) in chrome.runtime.setUninstallURL.
And allow empty URLs to be set to clear the uninstallation URL.
Added an optional callback, to know when setting the URL finished (or
failed).

BUG=518827
TEST=browser_tests --gtest_filter=ExtensionApiTest.ChromeRuntimeUninstallURL
R=kalman@chromium.org

Committed: https://crrev.com/28fc5b095a1d19eb104a76a08d55292831dce9fa
Cr-Commit-Position: refs/heads/master@{#342752}

[not at google - send to devlin, 2015-08-10 22:33:02]

lgtm with some cleanup

https://codereview.chromium.org/1282263002/diff/1/extensions/browser/api/runt...
File extensions/browser/api/runtime/runtime_api.cc (right):

https://codereview.chromium.org/1282263002/diff/1/extensions/browser/api/runt...
extensions/browser/api/runtime/runtime_api.cc:408: if (uninstall_url.is_empty()
|| !uninstall_url.SchemeIsHTTPOrHTTPS())
Second half of check is enough, and it's worth commenting like:

if (!uninstall_url.SchemeIsHTTPOrHTTPS()) {
  // In previous versions of Chrome non-http[s] URLs were allowed,
  // and may be stored in prefs. Now, they're disallowed, but old data
  // may exist.
  return;
}

https://codereview.chromium.org/1282263002/diff/1/extensions/browser/api/runt...
extensions/browser/api/runtime/runtime_api.cc:457: }
likewise here it could be just

if (!url_string.empty() && !GURL(url_string).SchemeIsHTTPOrHTTPS()) {
  return RespondNow(Error(kInvalidUrlError, url_string));
}


^^^ (yes you can simplify Error(ErrorUtils::FormatErrorMessage(kInvalidUrlError,
url_string)) --> Error(kInvalidUrlError, url_string))

https://codereview.chromium.org/1282263002/diff/1/extensions/common/api/runti...
File extensions/common/api/runtime.json (right):

https://codereview.chromium.org/1282263002/diff/1/extensions/common/api/runti...
extensions/common/api/runtime.json:195: "description": "URL to be opened after
the extension is uninstalled. This must be a HTTP or HTTPS URL. Set an empty
string to not open a new tab upon uninstallation."
"a HTTP" --> "an HTTP"

and really it's more correct to say "have an http: or https: scheme".

[robwu, 2015-08-10 23:17:32]

The CQ bit was checked by rob@robwu.nl

[robwu, 2015-08-10 23:17:33]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1282263002/#ps20001
(title: "Small cleanup")

[commit-bot: I haz the power, 2015-08-10 23:18:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1282263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1282263002/20001

[commit-bot: I haz the power, 2015-08-11 00:27:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-11 00:28:42]

Patchset 2 (id:??) landed as
https://crrev.com/28fc5b095a1d19eb104a76a08d55292831dce9fa
Cr-Commit-Position: refs/heads/master@{#342752}