Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1282263002: Restrict chrome.runtime.setUninstallURL to http(s) (Closed)

Created:
4 years, 3 months ago by robwu
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict chrome.runtime.setUninstallURL to http(s) Disallow URLs other than http(s) in chrome.runtime.setUninstallURL. And allow empty URLs to be set to clear the uninstallation URL. Added an optional callback, to know when setting the URL finished (or failed). BUG=518827 TEST=browser_tests --gtest_filter=ExtensionApiTest.ChromeRuntimeUninstallURL R=kalman@chromium.org Committed: https://crrev.com/28fc5b095a1d19eb104a76a08d55292831dce9fa Cr-Commit-Position: refs/heads/master@{#342752}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Small cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js View 1 chunk +12 lines, -0 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/common/api/runtime.json View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
robwu
4 years, 3 months ago (2015-08-10 14:47:12 UTC) #1
not at google - send to devlin
lgtm with some cleanup https://codereview.chromium.org/1282263002/diff/1/extensions/browser/api/runtime/runtime_api.cc File extensions/browser/api/runtime/runtime_api.cc (right): https://codereview.chromium.org/1282263002/diff/1/extensions/browser/api/runtime/runtime_api.cc#newcode408 extensions/browser/api/runtime/runtime_api.cc:408: if (uninstall_url.is_empty() || !uninstall_url.SchemeIsHTTPOrHTTPS()) Second ...
4 years, 3 months ago (2015-08-10 22:33:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282263002/20001
4 years, 3 months ago (2015-08-10 23:18:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2015-08-11 00:27:43 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2015-08-11 00:28:42 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28fc5b095a1d19eb104a76a08d55292831dce9fa
Cr-Commit-Position: refs/heads/master@{#342752}

Powered by Google App Engine
This is Rietveld 408576698