Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 1282013004: BackgroundSyncManager tracks client registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index f1637dff61e6d16e78a13dd84fe2e1f764ae2682..55d0eba93bd0fd60bc152a0255b1c2de53039a50 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -814,8 +814,9 @@ void ServiceWorkerVersion::DispatchFetchEvent(
}
}
-void ServiceWorkerVersion::DispatchSyncEvent(SyncRegistrationPtr registration,
- const StatusCallback& callback) {
+void ServiceWorkerVersion::DispatchSyncEvent(
+ BackgroundSyncRegistrationHandle::HandleId handle_id,
+ const StatusCallback& callback) {
OnBeginEvent();
DCHECK_EQ(ACTIVATED, status()) << status();
if (running_status() != RUNNING) {
@@ -823,7 +824,7 @@ void ServiceWorkerVersion::DispatchSyncEvent(SyncRegistrationPtr registration,
StartWorker(base::Bind(
&RunTaskAfterStartWorker, weak_factory_.GetWeakPtr(), callback,
base::Bind(&self::DispatchSyncEvent, weak_factory_.GetWeakPtr(),
- base::Passed(registration.Pass()), callback)));
+ handle_id, callback)));
return;
}
@@ -837,8 +838,8 @@ void ServiceWorkerVersion::DispatchSyncEvent(SyncRegistrationPtr registration,
}
background_sync_dispatcher_->Sync(
- registration.Pass(), base::Bind(&self::OnSyncEventFinished,
- weak_factory_.GetWeakPtr(), request_id));
+ handle_id, base::Bind(&self::OnSyncEventFinished,
+ weak_factory_.GetWeakPtr(), request_id));
}
void ServiceWorkerVersion::DispatchNotificationClickEvent(

Powered by Google App Engine
This is Rietveld 408576698