BackgroundSyncManager tracks client registrations

content/child/background_sync/background_sync_provider.cc

Index: content/child/background_sync/background_sync_provider.cc
diff --git a/content/child/background_sync/background_sync_provider.cc b/content/child/background_sync/background_sync_provider.cc
index bbe67d505b2797bf8eb19abbd3ae0c74b28d689b..b46583cc31e1eba21e098719d2ee2e8d91601857 100644
--- a/content/child/background_sync/background_sync_provider.cc
+++ b/content/child/background_sync/background_sync_provider.cc
@@ -58,6 +58,7 @@ void BackgroundSyncProvider::registerBackgroundSync(
                  base::Unretained(this), base::Passed(callbacksPtr.Pass())));
 }
 
+// TODO(jkarlin) remove |tag| parameter.
 void BackgroundSyncProvider::unregisterBackgroundSync(
     blink::WebSyncRegistration::Periodicity periodicity,
     int64_t id,

[michaeln, 2015/08/28 02:53:11]

this is an int handle_id? is that right?

[jkarlin, 2015/09/02 23:51:41]

Yes, conversion to int and the removal of tag will have to be done in follow-up
cls due to the three-legged Web* change.

TODO added.

@@ -73,7 +74,7 @@ void BackgroundSyncProvider::unregisterBackgroundSync(
   // base::Unretained is safe here, as the mojo channel will be deleted (and
   // will wipe its callbacks) before 'this' is deleted.
   GetBackgroundSyncServicePtr()->Unregister(
-      mojo::ConvertTo<BackgroundSyncPeriodicity>(periodicity), id, tag.utf8(),
+      mojo::ConvertTo<BackgroundSyncPeriodicity>(periodicity), id,
       service_worker_registration_id,
       base::Bind(&BackgroundSyncProvider::UnregisterCallback,
                  base::Unretained(this), base::Passed(callbacksPtr.Pass())));
@@ -138,6 +139,19 @@ void BackgroundSyncProvider::getPermissionStatus(
                  base::Unretained(this), base::Passed(callbacksPtr.Pass())));
 }
 
+void BackgroundSyncProvider::releaseRegistration(int64_t handle_id) {

[michaeln, 2015/08/28 02:53:11]

int?

[jkarlin, 2015/09/02 23:51:41]

Yes, but for a future CL as it requires a WebSyncProvider change.

+  GetBackgroundSyncServicePtr()->ReleaseRegistration(handle_id);
+}
+
+void BackgroundSyncProvider::DuplicateRegistrationHandle(
+    int64_t handle_id,

[michaeln, 2015/08/28 02:53:11]

int?

[jkarlin, 2015/09/02 23:51:41]

Done.

+    int64_t service_worker_registration_id,
+    const BackgroundSyncService::DuplicateRegistrationHandleCallback&
+        callback) {
+  GetBackgroundSyncServicePtr()->DuplicateRegistrationHandle(
+      handle_id, service_worker_registration_id, callback);
+}
+
 void BackgroundSyncProvider::RegisterCallback(
     scoped_ptr<blink::WebSyncRegistrationCallbacks> callbacks,
     BackgroundSyncError error,