Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1281953002: Fix QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest for GN browser tests. (Closed)

Created:
5 years, 4 months ago by jam
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest for GN browser tests. BUG=463180 Committed: https://crrev.com/c6a42394414078bce9d568f680f92a75c548de2d Cr-Commit-Position: refs/heads/master@{#342398}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M remoting/webapp/BUILD.gn View 3 chunks +16 lines, -4 lines 0 comments Download
M remoting/webapp/build-html.py View 2 chunks +2 lines, -1 line 1 comment Download
M remoting/webapp/files.gni View 4 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
https://codereview.chromium.org/1281953002/diff/1/remoting/webapp/build-html.py File remoting/webapp/build-html.py (right): https://codereview.chromium.org/1281953002/diff/1/remoting/webapp/build-html.py#newcode146 remoting/webapp/build-html.py:146: instrumented_js_files = set(args.instrument_js) - set(args.exclude_js) the comment on line ...
5 years, 4 months ago (2015-08-07 15:54:00 UTC) #2
brettw
lgtm
5 years, 4 months ago (2015-08-07 17:17:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281953002/1
5 years, 4 months ago (2015-08-07 17:34:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 18:50:47 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 18:51:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6a42394414078bce9d568f680f92a75c548de2d
Cr-Commit-Position: refs/heads/master@{#342398}

Powered by Google App Engine
This is Rietveld 408576698