remoting/webapp/build-html.py - Issue 1281953002: Fix QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest for GN browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/build-html.py

Issue 1281953002: Fix QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest for GN browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/build-html.py

diff --git a/remoting/webapp/build-html.py b/remoting/webapp/build-html.py

index d73ec67e80a7dd8bb73cab9bfd9c90866e672131..17d9a6ac1ec0de2158326cd2defd183a30e423fb 100755

--- a/remoting/webapp/build-html.py

+++ b/remoting/webapp/build-html.py

@@ -143,6 +143,7 @@ def main():

out_file = args.output_file

js_files = set(args.js) - set(args.exclude_js)

+ instrumented_js_files = set(args.instrument_js) - set(args.exclude_js)

jam 2015/08/07 15:54:00 the comment on line 126 above says this should be

# Create the output directory if it does not exist.

out_directory = os.path.dirname(out_file)

@@ -151,7 +152,7 @@ def main():

# Generate the main HTML file from the templates.

with open(out_file, 'w') as output:

- gen = GenerateWebappHtml(args.templates, js_files, args.instrument_js,

+ gen = GenerateWebappHtml(args.templates, js_files, instrumented_js_files,

args.template_dir)

gen.processTemplate(output, args.input_template, 0)

« no previous file with comments | « remoting/webapp/BUILD.gn ('k') | remoting/webapp/files.gni » ('j') | no next file with comments »