Componentize ComponentUpdaterConfigurator

components/update_client/update_query_params_delegate.h

Index: components/update_client/update_query_params_delegate.h
diff --git a/components/update_client/update_query_params_delegate.h b/components/update_client/update_query_params_delegate.h
index 0dd97ff530b3ce682876cd3210f79f416dce2d0d..8a4d74b0e32e83dcd672094bd68dec322ee93035 100644
--- a/components/update_client/update_query_params_delegate.h
+++ b/components/update_client/update_query_params_delegate.h
@@ -8,6 +8,7 @@
 #include <string>
 
 #include "base/basictypes.h"
+#include "components/version_info/version_info.h"
 
 namespace update_client {
 
@@ -23,6 +24,11 @@ class UpdateQueryParamsDelegate {
   // string should begin with a & character.
   virtual std::string GetExtraParams() = 0;
 
+  // Returns the value we use for the "updaterchannel=" and "prodchannel="

[Sorin Jianu, 2015/08/12 02:27:51]

This addition is suboptimal. UpdateQueryParamsDelegate used to be a pure
interface, now it has a static member. I agree that the design of the class is
debatable (has a ctor) and refactoring this is not in scope.

[droger, 2015/08/12 08:43:41]

I can move this function elsewhere if you prefer.
It can also be a free function (not in a class).

Just let me know.

[Sorin Jianu, 2015/08/12 17:16:55]

Free function would be better imho.

[droger, 2015/08/13 11:27:35]

I moved the function to UpdateQueryParams, it seems like a good fit.

+  // parameters. Possible return values include: "canary", "dev", "beta", and
+  // "stable".
+  static const char* GetChannelStringHelper(version_info::Channel channel);
+
  private:
   DISALLOW_COPY_AND_ASSIGN(UpdateQueryParamsDelegate);
 };