Componentize ComponentUpdaterConfigurator

components/update_client/update_query_params_delegate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UPDATE_CLIENT_UPDATE_QUERY_PARAMS_DELEGATE_H_
 #define COMPONENTS_UPDATE_CLIENT_UPDATE_QUERY_PARAMS_DELEGATE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "components/version_info/version_info.h"
 
 namespace update_client {
 
 // Embedders can specify an UpdateQueryParamsDelegate to provide additional
 // custom parameters. If not specified (Set is never called), no additional
 // parameters are added.
 class UpdateQueryParamsDelegate {
  public:
   UpdateQueryParamsDelegate();
   virtual ~UpdateQueryParamsDelegate();
 
   // Returns additional parameters, if any. If there are any parameters, the
   // string should begin with a & character.
   virtual std::string GetExtraParams() = 0;
 
+  // Returns the value we use for the "updaterchannel=" and "prodchannel="

[Sorin Jianu, 2015/08/12 02:27:51]

This addition is suboptimal. UpdateQueryParamsDelegate used to be a pure
interface, now it has a static member. I agree that the design of the class is
debatable (has a ctor) and refactoring this is not in scope.

[droger, 2015/08/12 08:43:41]

I can move this function elsewhere if you prefer.
It can also be a free function (not in a class).

Just let me know.

[Sorin Jianu, 2015/08/12 17:16:55]

Free function would be better imho.

[droger, 2015/08/13 11:27:35]

I moved the function to UpdateQueryParams, it seems like a good fit.

+  // parameters. Possible return values include: "canary", "dev", "beta", and
+  // "stable".
+  static const char* GetChannelStringHelper(version_info::Channel channel);
+
  private:
   DISALLOW_COPY_AND_ASSIGN(UpdateQueryParamsDelegate);
 };
 
 }  // namespace update_client
 
 #endif  // COMPONENTS_UPDATE_CLIENT_UPDATE_QUERY_PARAMS_DELEGATE_H_