Issue 1281783004: ASSERTION FAILED: !m_parsedCalculation in blink::CSSPropertyParser::parseValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1281783004: ASSERTION FAILED: !m_parsedCalculation in blink::CSSPropertyParser::parseValue (Closed)

Created:
5 years, 4 months ago by rwlbuis

Modified:
5 years, 4 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

ASSERTION FAILED: !m_parsedCalculation in blink::CSSPropertyParser::parseValue After calling validUnit a CSSPrimitiveValue is supposed to be created. In this case the hasAngle check may prevent this, so do this check first. BUG=518690 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200284

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -0 lines)			Patch
A	LayoutTests/fast/css/motion-degrees-calc-crash.html	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/css/motion-degrees-calc-crash-expected.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281783004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281783004/1

5 years, 4 months ago (2015-08-11 01:14:45 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-11 02:19:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200284

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages