Source/core/css/parser/CSSPropertyParser.cpp - Issue 1281783004: ASSERTION FAILED: !m_parsedCalculation in blink::CSSPropertyParser::parseValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 1281783004: ASSERTION FAILED: !m_parsedCalculation in blink::CSSPropertyParser::parseValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp

index 415f1c423d1ebccb836c0fb79e4af934945a7574..bf6ae705ab3d0d4eafd47a67cdc7bfefe7e9422b 100644

--- a/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/Source/core/css/parser/CSSPropertyParser.cpp

@@ -8135,7 +8135,7 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::parseMotionRotation()

if ((value->id == CSSValueAuto || value->id == CSSValueReverse) && !hasAutoOrReverse) {

list->append(cssValuePool().createIdentifierValue(value->id));

hasAutoOrReverse = true;

- } else if (validUnit(value, FAngle) && !hasAngle) {

+ } else if (!hasAngle && validUnit(value, FAngle)) {

list->append(createPrimitiveNumericValue(value));

hasAngle = true;

} else {

« no previous file with comments | « LayoutTests/fast/css/motion-degrees-calc-crash-expected.html ('k') | no next file » | no next file with comments »