Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: tests/corelib/list_get_range_test.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/corelib/list_get_range_test.dart
diff --git a/tests/corelib/list_get_range_test.dart b/tests/corelib/list_get_range_test.dart
index 88baeb6329504f0c6b487ab08889ba4862788a3d..07ffa56cfc048badb06e3c114285c7bf431d3b22 100644
--- a/tests/corelib/list_get_range_test.dart
+++ b/tests/corelib/list_get_range_test.dart
@@ -3,43 +3,54 @@
// BSD-style license that can be found in the LICENSE file.
main() {
- Expect.listEquals([], [].getRange(0, 0));
- Expect.listEquals([], const [].getRange(0, 0));
-
- Expect.listEquals([], [].getRange(-1, 0));
- Expect.listEquals([], const [].getRange(-1, 0));
-
- Expect.listEquals([1, 2], [1, 2].getRange(0, 2));
- Expect.listEquals([1, 2], const [1, 2].getRange(0, 2));
-
- Expect.listEquals([1], [1, 2].getRange(0, 1));
- Expect.listEquals([1], const [1, 2].getRange(0, 1));
-
- Expect.listEquals([2], [1, 2].getRange(1, 1));
- Expect.listEquals([2], const [1, 2].getRange(1, 1));
-
- Expect.listEquals([], [1, 2].getRange(0, 0));
- Expect.listEquals([], const [1, 2].getRange(0, 0));
-
- Expect.listEquals([2, 3], [1, 2, 3, 4].getRange(1, 2));
- Expect.listEquals([2, 3], const [1, 2, 3, 4].getRange(1, 2));
-
- Expect.listEquals([2, 3], [1, 2, 3, 4].getRange(1, 2));
- Expect.listEquals([2, 3], const [1, 2, 3, 4].getRange(1, 2));
-
- expectIAE(() => [].getRange(0, -1));
- expectIAE(() => const [].getRange(-1, -1));
-
- expectIOORE(() => [].getRange(-1, 1));
- expectIOORE(() => [].getRange(1, 1));
- expectIOORE(() => [1].getRange(0, 2));
- expectIOORE(() => [1].getRange(1, 1));
-}
-
-void expectIOORE(Function f) {
- Expect.throws(f, (e) => e is RangeError);
+ Expect.listEquals([], [].sublist(0, 0));
+ Expect.listEquals([], const [].sublist(0, 0));
+
+
+ Expect.listEquals([1, 2], [1, 2].sublist(0, 2));
+ Expect.listEquals([1, 2], const [1, 2].sublist(0, 2));
+
+ Expect.listEquals([1], [1, 2].sublist(0, 1));
+ Expect.listEquals([1], const [1, 2].sublist(0, 1));
+
+ Expect.listEquals([2], [1, 2].sublist(1, 2));
+ Expect.listEquals([2], const [1, 2].sublist(1, 2));
+
+ Expect.listEquals([], [1, 2].sublist(0, 0));
+ Expect.listEquals([], const [1, 2].sublist(0, 0));
+
+ Expect.listEquals([2, 3], [1, 2, 3, 4].sublist(1, 3));
+ Expect.listEquals([2, 3], const [1, 2, 3, 4].sublist(1, 3));
+
+ Expect.listEquals([2, 3], [1, 2, 3, 4].sublist(1, 3));
+ Expect.listEquals([2, 3], const [1, 2, 3, 4].sublist(1, 3));
+
+ expectAE(() => [].sublist(-1, null));
+ expectAE(() => const [].sublist(-1, null));
+ expectAE(() => [].sublist(-1, 0));
+ expectAE(() => const [].sublist(-1, 0));
+ expectAE(() => [].sublist(-1, -1));
+ expectAE(() => const [].sublist(-1, -1));
+ expectAE(() => [].sublist(-1, 1));
+ expectAE(() => const [].sublist(-1, 1));
+ expectAE(() => [].sublist(0, -1));
+ expectAE(() => const [].sublist(0, -1));
+ expectAE(() => [].sublist(0, 1));
+ expectAE(() => const [].sublist(0, 1));
+ expectAE(() => [].sublist(1, null));
+ expectAE(() => const [].sublist(1, null));
+ expectAE(() => [].sublist(1, 0));
+ expectAE(() => const [].sublist(1, 0));
+ expectAE(() => [].sublist(1, -1));
+ expectAE(() => const [].sublist(1, -1));
+ expectAE(() => [].sublist(1, 1));
+ expectAE(() => const [].sublist(1, 1));
+
+ expectAE(() => [1].sublist(0, 2));
+ expectAE(() => [1].sublist(1, 2));
+ expectAE(() => [1].sublist(1, 0));
}
-void expectIAE(Function f) {
+void expectAE(Function f) {
Expect.throws(f, (e) => e is ArgumentError);
}

Powered by Google App Engine
This is Rietveld 408576698