Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: tests/corelib/list_get_range_test.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 main() { 5 main() {
6 Expect.listEquals([], [].getRange(0, 0)); 6 Expect.listEquals([], [].sublist(0, 0));
7 Expect.listEquals([], const [].getRange(0, 0)); 7 Expect.listEquals([], const [].sublist(0, 0));
8 8
9 Expect.listEquals([], [].getRange(-1, 0));
10 Expect.listEquals([], const [].getRange(-1, 0));
11 9
12 Expect.listEquals([1, 2], [1, 2].getRange(0, 2)); 10 Expect.listEquals([1, 2], [1, 2].sublist(0, 2));
13 Expect.listEquals([1, 2], const [1, 2].getRange(0, 2)); 11 Expect.listEquals([1, 2], const [1, 2].sublist(0, 2));
14 12
15 Expect.listEquals([1], [1, 2].getRange(0, 1)); 13 Expect.listEquals([1], [1, 2].sublist(0, 1));
16 Expect.listEquals([1], const [1, 2].getRange(0, 1)); 14 Expect.listEquals([1], const [1, 2].sublist(0, 1));
17 15
18 Expect.listEquals([2], [1, 2].getRange(1, 1)); 16 Expect.listEquals([2], [1, 2].sublist(1, 2));
19 Expect.listEquals([2], const [1, 2].getRange(1, 1)); 17 Expect.listEquals([2], const [1, 2].sublist(1, 2));
20 18
21 Expect.listEquals([], [1, 2].getRange(0, 0)); 19 Expect.listEquals([], [1, 2].sublist(0, 0));
22 Expect.listEquals([], const [1, 2].getRange(0, 0)); 20 Expect.listEquals([], const [1, 2].sublist(0, 0));
23 21
24 Expect.listEquals([2, 3], [1, 2, 3, 4].getRange(1, 2)); 22 Expect.listEquals([2, 3], [1, 2, 3, 4].sublist(1, 3));
25 Expect.listEquals([2, 3], const [1, 2, 3, 4].getRange(1, 2)); 23 Expect.listEquals([2, 3], const [1, 2, 3, 4].sublist(1, 3));
26 24
27 Expect.listEquals([2, 3], [1, 2, 3, 4].getRange(1, 2)); 25 Expect.listEquals([2, 3], [1, 2, 3, 4].sublist(1, 3));
28 Expect.listEquals([2, 3], const [1, 2, 3, 4].getRange(1, 2)); 26 Expect.listEquals([2, 3], const [1, 2, 3, 4].sublist(1, 3));
29 27
30 expectIAE(() => [].getRange(0, -1)); 28 expectAE(() => [].sublist(-1, null));
31 expectIAE(() => const [].getRange(-1, -1)); 29 expectAE(() => const [].sublist(-1, null));
30 expectAE(() => [].sublist(-1, 0));
31 expectAE(() => const [].sublist(-1, 0));
32 expectAE(() => [].sublist(-1, -1));
33 expectAE(() => const [].sublist(-1, -1));
34 expectAE(() => [].sublist(-1, 1));
35 expectAE(() => const [].sublist(-1, 1));
36 expectAE(() => [].sublist(0, -1));
37 expectAE(() => const [].sublist(0, -1));
38 expectAE(() => [].sublist(0, 1));
39 expectAE(() => const [].sublist(0, 1));
40 expectAE(() => [].sublist(1, null));
41 expectAE(() => const [].sublist(1, null));
42 expectAE(() => [].sublist(1, 0));
43 expectAE(() => const [].sublist(1, 0));
44 expectAE(() => [].sublist(1, -1));
45 expectAE(() => const [].sublist(1, -1));
46 expectAE(() => [].sublist(1, 1));
47 expectAE(() => const [].sublist(1, 1));
32 48
33 expectIOORE(() => [].getRange(-1, 1)); 49 expectAE(() => [1].sublist(0, 2));
34 expectIOORE(() => [].getRange(1, 1)); 50 expectAE(() => [1].sublist(1, 2));
35 expectIOORE(() => [1].getRange(0, 2)); 51 expectAE(() => [1].sublist(1, 0));
36 expectIOORE(() => [1].getRange(1, 1));
37 } 52 }
38 53
39 void expectIOORE(Function f) { 54 void expectAE(Function f) {
40 Expect.throws(f, (e) => e is RangeError);
41 }
42
43 void expectIAE(Function f) {
44 Expect.throws(f, (e) => e is ArgumentError); 55 Expect.throws(f, (e) => e is ArgumentError);
45 } 56 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698