Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: sdk/lib/svg/dartium/svg_dartium.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/svg/dartium/svg_dartium.dart
diff --git a/sdk/lib/svg/dartium/svg_dartium.dart b/sdk/lib/svg/dartium/svg_dartium.dart
index 0e4935a978c2f414a6961ff480a13d679af3cc63..b6fc12e72193e88708fa11e47867e6bcf70d6cdf 100644
--- a/sdk/lib/svg/dartium/svg_dartium.dart
+++ b/sdk/lib/svg/dartium/svg_dartium.dart
@@ -3494,8 +3494,13 @@ class LengthList extends NativeFieldWrapperClass1 implements List<Length> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ List<Length> sublist(int start, [int end]) {
+ if (end == null) end = length;
+ return Lists.getRange(this, start, end, <Length>[]);
+ }
+
List<Length> getRange(int start, int rangeLength) =>
- Lists.getRange(this, start, rangeLength, <Length>[]);
+ sublist(start, start + rangeLength);
Map<int, Length> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -4204,8 +4209,13 @@ class NumberList extends NativeFieldWrapperClass1 implements List<Number> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ List<Number> sublist(int start, [int end]) {
+ if (end == null) end = length;
+ return Lists.getRange(this, start, end, <Number>[]);
+ }
+
List<Number> getRange(int start, int rangeLength) =>
- Lists.getRange(this, start, rangeLength, <Number>[]);
+ sublist(start, start + rangeLength);
Map<int, Number> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -5390,8 +5400,13 @@ class PathSegList extends NativeFieldWrapperClass1 implements List<PathSeg> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ List<PathSeg> sublist(int start, [int end]) {
+ if (end == null) end = length;
+ return Lists.getRange(this, start, end, <PathSeg>[]);
+ }
+
List<PathSeg> getRange(int start, int rangeLength) =>
- Lists.getRange(this, start, rangeLength, <PathSeg>[]);
+ sublist(start, start + rangeLength);
Map<int, PathSeg> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -6381,8 +6396,13 @@ class StringList extends NativeFieldWrapperClass1 implements List<String> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ List<String> sublist(int start, [int end]) {
+ if (end == null) end = length;
+ return Lists.getRange(this, start, end, <String>[]);
+ }
+
List<String> getRange(int start, int rangeLength) =>
- Lists.getRange(this, start, rangeLength, <String>[]);
+ sublist(start, start + rangeLength);
Map<int, String> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -7641,8 +7661,13 @@ class TransformList extends NativeFieldWrapperClass1 implements List<Transform>
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ List<Transform> sublist(int start, [int end]) {
+ if (end == null) end = length;
+ return Lists.getRange(this, start, end, <Transform>[]);
+ }
+
List<Transform> getRange(int start, int rangeLength) =>
- Lists.getRange(this, start, rangeLength, <Transform>[]);
+ sublist(start, start + rangeLength);
Map<int, Transform> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -8223,8 +8248,13 @@ class _ElementInstanceList extends NativeFieldWrapperClass1 implements List<Elem
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ List<ElementInstance> sublist(int start, [int end]) {
+ if (end == null) end = length;
+ return Lists.getRange(this, start, end, <ElementInstance>[]);
+ }
+
List<ElementInstance> getRange(int start, int rangeLength) =>
- Lists.getRange(this, start, rangeLength, <ElementInstance>[]);
+ sublist(start, start + rangeLength);
Map<int, ElementInstance> asMap() =>
IterableMixinWorkaround.asMapList(this);

Powered by Google App Engine
This is Rietveld 408576698