Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Side by Side Diff: sdk/lib/svg/dartium/svg_dartium.dart

Issue 12817003: Change getRange to sublist. Make getRange deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 library dart.dom.svg; 1 library dart.dom.svg;
2 2
3 import 'dart:async'; 3 import 'dart:async';
4 import 'dart:collection'; 4 import 'dart:collection';
5 import 'dart:html'; 5 import 'dart:html';
6 import 'dart:html_common'; 6 import 'dart:html_common';
7 import 'dart:nativewrappers'; 7 import 'dart:nativewrappers';
8 // DO NOT EDIT 8 // DO NOT EDIT
9 // Auto-generated dart:svg library. 9 // Auto-generated dart:svg library.
10 10
(...skipping 3476 matching lines...) Expand 10 before | Expand all | Expand 10 after
3487 } 3487 }
3488 3488
3489 void removeRange(int start, int rangeLength) { 3489 void removeRange(int start, int rangeLength) {
3490 throw new UnsupportedError("Cannot removeRange on immutable List."); 3490 throw new UnsupportedError("Cannot removeRange on immutable List.");
3491 } 3491 }
3492 3492
3493 void insertRange(int start, int rangeLength, [Length initialValue]) { 3493 void insertRange(int start, int rangeLength, [Length initialValue]) {
3494 throw new UnsupportedError("Cannot insertRange on immutable List."); 3494 throw new UnsupportedError("Cannot insertRange on immutable List.");
3495 } 3495 }
3496 3496
3497 List<Length> sublist(int start, [int end]) {
3498 if (end == null) end = length;
3499 return Lists.getRange(this, start, end, <Length>[]);
3500 }
3501
3497 List<Length> getRange(int start, int rangeLength) => 3502 List<Length> getRange(int start, int rangeLength) =>
3498 Lists.getRange(this, start, rangeLength, <Length>[]); 3503 sublist(start, start + rangeLength);
3499 3504
3500 Map<int, Length> asMap() => 3505 Map<int, Length> asMap() =>
3501 IterableMixinWorkaround.asMapList(this); 3506 IterableMixinWorkaround.asMapList(this);
3502 3507
3503 // -- end List<Length> mixins. 3508 // -- end List<Length> mixins.
3504 3509
3505 @DomName('SVGLengthList.appendItem') 3510 @DomName('SVGLengthList.appendItem')
3506 @DocsEditable 3511 @DocsEditable
3507 Length appendItem(Length item) native "SVGLengthList_appendItem_Callback"; 3512 Length appendItem(Length item) native "SVGLengthList_appendItem_Callback";
3508 3513
(...skipping 688 matching lines...) Expand 10 before | Expand all | Expand 10 after
4197 } 4202 }
4198 4203
4199 void removeRange(int start, int rangeLength) { 4204 void removeRange(int start, int rangeLength) {
4200 throw new UnsupportedError("Cannot removeRange on immutable List."); 4205 throw new UnsupportedError("Cannot removeRange on immutable List.");
4201 } 4206 }
4202 4207
4203 void insertRange(int start, int rangeLength, [Number initialValue]) { 4208 void insertRange(int start, int rangeLength, [Number initialValue]) {
4204 throw new UnsupportedError("Cannot insertRange on immutable List."); 4209 throw new UnsupportedError("Cannot insertRange on immutable List.");
4205 } 4210 }
4206 4211
4212 List<Number> sublist(int start, [int end]) {
4213 if (end == null) end = length;
4214 return Lists.getRange(this, start, end, <Number>[]);
4215 }
4216
4207 List<Number> getRange(int start, int rangeLength) => 4217 List<Number> getRange(int start, int rangeLength) =>
4208 Lists.getRange(this, start, rangeLength, <Number>[]); 4218 sublist(start, start + rangeLength);
4209 4219
4210 Map<int, Number> asMap() => 4220 Map<int, Number> asMap() =>
4211 IterableMixinWorkaround.asMapList(this); 4221 IterableMixinWorkaround.asMapList(this);
4212 4222
4213 // -- end List<Number> mixins. 4223 // -- end List<Number> mixins.
4214 4224
4215 @DomName('SVGNumberList.appendItem') 4225 @DomName('SVGNumberList.appendItem')
4216 @DocsEditable 4226 @DocsEditable
4217 Number appendItem(Number item) native "SVGNumberList_appendItem_Callback"; 4227 Number appendItem(Number item) native "SVGNumberList_appendItem_Callback";
4218 4228
(...skipping 1164 matching lines...) Expand 10 before | Expand all | Expand 10 after
5383 } 5393 }
5384 5394
5385 void removeRange(int start, int rangeLength) { 5395 void removeRange(int start, int rangeLength) {
5386 throw new UnsupportedError("Cannot removeRange on immutable List."); 5396 throw new UnsupportedError("Cannot removeRange on immutable List.");
5387 } 5397 }
5388 5398
5389 void insertRange(int start, int rangeLength, [PathSeg initialValue]) { 5399 void insertRange(int start, int rangeLength, [PathSeg initialValue]) {
5390 throw new UnsupportedError("Cannot insertRange on immutable List."); 5400 throw new UnsupportedError("Cannot insertRange on immutable List.");
5391 } 5401 }
5392 5402
5403 List<PathSeg> sublist(int start, [int end]) {
5404 if (end == null) end = length;
5405 return Lists.getRange(this, start, end, <PathSeg>[]);
5406 }
5407
5393 List<PathSeg> getRange(int start, int rangeLength) => 5408 List<PathSeg> getRange(int start, int rangeLength) =>
5394 Lists.getRange(this, start, rangeLength, <PathSeg>[]); 5409 sublist(start, start + rangeLength);
5395 5410
5396 Map<int, PathSeg> asMap() => 5411 Map<int, PathSeg> asMap() =>
5397 IterableMixinWorkaround.asMapList(this); 5412 IterableMixinWorkaround.asMapList(this);
5398 5413
5399 // -- end List<PathSeg> mixins. 5414 // -- end List<PathSeg> mixins.
5400 5415
5401 @DomName('SVGPathSegList.appendItem') 5416 @DomName('SVGPathSegList.appendItem')
5402 @DocsEditable 5417 @DocsEditable
5403 PathSeg appendItem(PathSeg newItem) native "SVGPathSegList_appendItem_Callback "; 5418 PathSeg appendItem(PathSeg newItem) native "SVGPathSegList_appendItem_Callback ";
5404 5419
(...skipping 969 matching lines...) Expand 10 before | Expand all | Expand 10 after
6374 } 6389 }
6375 6390
6376 void removeRange(int start, int rangeLength) { 6391 void removeRange(int start, int rangeLength) {
6377 throw new UnsupportedError("Cannot removeRange on immutable List."); 6392 throw new UnsupportedError("Cannot removeRange on immutable List.");
6378 } 6393 }
6379 6394
6380 void insertRange(int start, int rangeLength, [String initialValue]) { 6395 void insertRange(int start, int rangeLength, [String initialValue]) {
6381 throw new UnsupportedError("Cannot insertRange on immutable List."); 6396 throw new UnsupportedError("Cannot insertRange on immutable List.");
6382 } 6397 }
6383 6398
6399 List<String> sublist(int start, [int end]) {
6400 if (end == null) end = length;
6401 return Lists.getRange(this, start, end, <String>[]);
6402 }
6403
6384 List<String> getRange(int start, int rangeLength) => 6404 List<String> getRange(int start, int rangeLength) =>
6385 Lists.getRange(this, start, rangeLength, <String>[]); 6405 sublist(start, start + rangeLength);
6386 6406
6387 Map<int, String> asMap() => 6407 Map<int, String> asMap() =>
6388 IterableMixinWorkaround.asMapList(this); 6408 IterableMixinWorkaround.asMapList(this);
6389 6409
6390 // -- end List<String> mixins. 6410 // -- end List<String> mixins.
6391 6411
6392 @DomName('SVGStringList.appendItem') 6412 @DomName('SVGStringList.appendItem')
6393 @DocsEditable 6413 @DocsEditable
6394 String appendItem(String item) native "SVGStringList_appendItem_Callback"; 6414 String appendItem(String item) native "SVGStringList_appendItem_Callback";
6395 6415
(...skipping 1238 matching lines...) Expand 10 before | Expand all | Expand 10 after
7634 } 7654 }
7635 7655
7636 void removeRange(int start, int rangeLength) { 7656 void removeRange(int start, int rangeLength) {
7637 throw new UnsupportedError("Cannot removeRange on immutable List."); 7657 throw new UnsupportedError("Cannot removeRange on immutable List.");
7638 } 7658 }
7639 7659
7640 void insertRange(int start, int rangeLength, [Transform initialValue]) { 7660 void insertRange(int start, int rangeLength, [Transform initialValue]) {
7641 throw new UnsupportedError("Cannot insertRange on immutable List."); 7661 throw new UnsupportedError("Cannot insertRange on immutable List.");
7642 } 7662 }
7643 7663
7664 List<Transform> sublist(int start, [int end]) {
7665 if (end == null) end = length;
7666 return Lists.getRange(this, start, end, <Transform>[]);
7667 }
7668
7644 List<Transform> getRange(int start, int rangeLength) => 7669 List<Transform> getRange(int start, int rangeLength) =>
7645 Lists.getRange(this, start, rangeLength, <Transform>[]); 7670 sublist(start, start + rangeLength);
7646 7671
7647 Map<int, Transform> asMap() => 7672 Map<int, Transform> asMap() =>
7648 IterableMixinWorkaround.asMapList(this); 7673 IterableMixinWorkaround.asMapList(this);
7649 7674
7650 // -- end List<Transform> mixins. 7675 // -- end List<Transform> mixins.
7651 7676
7652 @DomName('SVGTransformList.appendItem') 7677 @DomName('SVGTransformList.appendItem')
7653 @DocsEditable 7678 @DocsEditable
7654 Transform appendItem(Transform item) native "SVGTransformList_appendItem_Callb ack"; 7679 Transform appendItem(Transform item) native "SVGTransformList_appendItem_Callb ack";
7655 7680
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
8216 } 8241 }
8217 8242
8218 void removeRange(int start, int rangeLength) { 8243 void removeRange(int start, int rangeLength) {
8219 throw new UnsupportedError("Cannot removeRange on immutable List."); 8244 throw new UnsupportedError("Cannot removeRange on immutable List.");
8220 } 8245 }
8221 8246
8222 void insertRange(int start, int rangeLength, [ElementInstance initialValue]) { 8247 void insertRange(int start, int rangeLength, [ElementInstance initialValue]) {
8223 throw new UnsupportedError("Cannot insertRange on immutable List."); 8248 throw new UnsupportedError("Cannot insertRange on immutable List.");
8224 } 8249 }
8225 8250
8251 List<ElementInstance> sublist(int start, [int end]) {
8252 if (end == null) end = length;
8253 return Lists.getRange(this, start, end, <ElementInstance>[]);
8254 }
8255
8226 List<ElementInstance> getRange(int start, int rangeLength) => 8256 List<ElementInstance> getRange(int start, int rangeLength) =>
8227 Lists.getRange(this, start, rangeLength, <ElementInstance>[]); 8257 sublist(start, start + rangeLength);
8228 8258
8229 Map<int, ElementInstance> asMap() => 8259 Map<int, ElementInstance> asMap() =>
8230 IterableMixinWorkaround.asMapList(this); 8260 IterableMixinWorkaround.asMapList(this);
8231 8261
8232 // -- end List<ElementInstance> mixins. 8262 // -- end List<ElementInstance> mixins.
8233 8263
8234 @DomName('SVGElementInstanceList.item') 8264 @DomName('SVGElementInstanceList.item')
8235 @DocsEditable 8265 @DocsEditable
8236 ElementInstance item(int index) native "SVGElementInstanceList_item_Callback"; 8266 ElementInstance item(int index) native "SVGElementInstanceList_item_Callback";
8237 8267
(...skipping 486 matching lines...) Expand 10 before | Expand all | Expand 10 after
8724 @DocsEditable 8754 @DocsEditable
8725 @DomName('SVGVKernElement') 8755 @DomName('SVGVKernElement')
8726 class _SVGVKernElement extends SvgElement { 8756 class _SVGVKernElement extends SvgElement {
8727 _SVGVKernElement.internal() : super.internal(); 8757 _SVGVKernElement.internal() : super.internal();
8728 8758
8729 @DomName('SVGVKernElement.SVGVKernElement') 8759 @DomName('SVGVKernElement.SVGVKernElement')
8730 @DocsEditable 8760 @DocsEditable
8731 factory _SVGVKernElement() => _SvgElementFactoryProvider.createSvgElement_tag( "vkern"); 8761 factory _SVGVKernElement() => _SvgElementFactoryProvider.createSvgElement_tag( "vkern");
8732 8762
8733 } 8763 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698