Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1281663003: Media: Introduce addSourceBuffer which takes an unparsed codecs string (Closed)

Created:
5 years, 4 months ago by servolk
Modified:
5 years, 4 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media: Introduce addSourceBuffer which takes an unparsed codecs string Introduce an overload of WebMediaSourceImpl::addSourceBuffer that takes codecs as an unparsed string and parses it using media::ParseCodecString. This will allow us to remove the other overload, which expects a parsed vector of codecs. This will consolidate parsing of the codecs string in media and will allow us to remove duplicated parsing code in blink::ContentType::codecs BUG=none Committed: https://crrev.com/b21b828451bfe2f3befc8f1735846b0cad3f1310 Cr-Commit-Position: refs/heads/master@{#343058}

Patch Set 1 #

Patch Set 2 : buildfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M media/blink/webmediasource_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/blink/webmediasource_impl.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
servolk
5 years, 4 months ago (2015-08-07 01:58:48 UTC) #2
servolk
On 2015/08/07 01:58:48, servolk wrote: The next step is going to be https://codereview.chromium.org/1283573002/ And after ...
5 years, 4 months ago (2015-08-07 21:46:08 UTC) #3
DaleCurtis
Sorry, I don't know this code well enough to review.
5 years, 4 months ago (2015-08-07 22:21:23 UTC) #5
wolenetz
lgtm
5 years, 4 months ago (2015-08-12 17:29:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281663003/20001
5 years, 4 months ago (2015-08-12 17:32:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 18:22:28 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 18:23:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b21b828451bfe2f3befc8f1735846b0cad3f1310
Cr-Commit-Position: refs/heads/master@{#343058}

Powered by Google App Engine
This is Rietveld 408576698