Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1282883004: Remove the old WebMediaSourceImpl::addSourceBuffer overload (Closed)

Created:
5 years, 4 months ago by servolk
Modified:
5 years, 4 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@parse-codecs-in-media
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the old WebMediaSourceImpl::addSourceBuffer overload Complete the transition to using the new addSourceBuffer overload that takes codecs as an unparsed string. BUG=none Committed: https://crrev.com/b1fc55eebc36abcb85e5f6859914f7d90efcbd1d Cr-Commit-Position: refs/heads/master@{#343477}

Patch Set 1 #

Patch Set 2 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M media/blink/webmediasource_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/blink/webmediasource_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
servolk
5 years, 4 months ago (2015-08-14 00:05:40 UTC) #2
wolenetz
lgtm % s/WebSourceBufferImpl/WebMediaSourceImpl/ in CL description. Thanks again for doing this code coalescence!
5 years, 4 months ago (2015-08-14 20:13:30 UTC) #3
servolk
On 2015/08/14 20:13:30, wolenetz wrote: > lgtm % s/WebSourceBufferImpl/WebMediaSourceImpl/ in CL description. Thanks again > ...
5 years, 4 months ago (2015-08-14 20:23:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282883004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282883004/20001
5 years, 4 months ago (2015-08-14 20:23:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-14 20:28:42 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 20:29:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1fc55eebc36abcb85e5f6859914f7d90efcbd1d
Cr-Commit-Position: refs/heads/master@{#343477}

Powered by Google App Engine
This is Rietveld 408576698