Make zoom filter independent of the layer size.

Make zoom filter independent of the layer size.

Instead of passing a rect based on the size of the layer into the filter
operation, just pass the zoom amount, and compute the rect when applying
the filter, since the size of the texture being filtered is known there.

This deactivates the zoom filter entirely (and sets values to 0's in the
IPC code) until https://bugs.webkit.org/show_bug.cgi?id=112221 rolls into
chromium.

R=piman,jamesr
BUG=161936
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187901

[danakj, 2013-03-13 02:20:41]

+cdn for content/common/cc_messages.cc (The values for the zoom filter are
changing from rect+float to int+float. This patch disables IPC for the old
values and will enable it for the new ones with an ifdef guard waiting for a
webkit roll.)

[danakj, 2013-03-13 02:54:44]

+senorblanco

[danakj, 2013-03-13 02:56:10]

Lots of reviewers...

piman@ can you please review everything.

cdn@ please review the IPC change.

jamesr@ FYI for https://bugs.webkit.org/show_bug.cgi?id=112221

senorblanco@ FYI for RenderSurfaceFilters.

[piman, 2013-03-13 06:01:14]

https://codereview.chromium.org/12816002/diff/2018/content/common/cc_messages.cc
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/12816002/diff/2018/content/common/cc_messages...
content/common/cc_messages.cc:44: #endif
It's a bit awkward to leave it like that, where the current code (pre-roll)
doesn't write anything but reads a float and an int. It means it'll mess up the
rest of the message deserialization.
Let's just write something that matches what the reader expects (or change the
reader to not read anything if !NEW_ZOOM_FILTER).

[danakj, 2013-03-13 06:05:48]

https://codereview.chromium.org/12816002/diff/2018/content/common/cc_messages.cc
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/12816002/diff/2018/content/common/cc_messages...
content/common/cc_messages.cc:44: #endif
On 2013/03/13 06:01:14, piman wrote:
> It's a bit awkward to leave it like that, where the current code (pre-roll)
> doesn't write anything but reads a float and an int. It means it'll mess up
the
> rest of the message deserialization.
> Let's just write something that matches what the reader expects (or change the
> reader to not read anything if !True.NEW_ZOOM_FILTER).

True. Ok, made it not read anything.

[piman, 2013-03-13 06:06:45]

lgtm

[jschuh, 2013-03-13 15:19:58]

ipc security lgtm

[danakj, 2013-03-13 15:21:15]

I added guards that the zoom filter values are >= 0, as requested by justin.

[Stephen White, 2013-03-13 15:21:18]

LGTM too

[commit-bot: I haz the power, 2013-03-13 15:21:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12816002/17001

[commit-bot: I haz the power, 2013-03-13 15:21:39]

Presubmit check for 12816002-17001 failed and returned exit status 1.

INFO:root:Found 6 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/cc/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ui/compositor/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    ash/magnifier/partial_magnification_controller.cc

Presubmit checks took 1.3s to calculate.

[danakj, 2013-03-13 15:25:17]

TBR=sky for removing 2 arguments from the callsite in
ash/magnifier/partial_magnification_controller.cc

[danakj, 2013-03-13 15:25:35]

TBR=sky for removing 2 arguments from the callsite in
ash/magnifier/partial_magnification_controller.cc

[commit-bot: I haz the power, 2013-03-13 15:26:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12816002/17001

[commit-bot: I haz the power, 2013-03-13 15:29:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12816002/30001

[danakj, 2013-03-13 18:27:43]

Committed patchset #5 manually as r187901 (presubmit successful).