LayoutTests/fast/forms/number/number-type-update-by-change-event.html - Issue 128133002: Update of change event for input type number

Unified Diff: LayoutTests/fast/forms/number/number-type-update-by-change-event.html

Issue 128133002: Update of change event for input type number (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review updates Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/forms/number/number-type-update-by-change-event-expected.txt » ('j') | Source/core/html/shadow/SpinButtonElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/forms/number/number-type-update-by-change-event.html

diff --git a/LayoutTests/fast/forms/number/number-type-update-by-change-event.html b/LayoutTests/fast/forms/number/number-type-update-by-change-event.html

index db6a233ccb2758c46db91e18149e8ed8df72313d..4b4e75575f2269cb27e45f7b478085ae9f630d75 100644

--- a/LayoutTests/fast/forms/number/number-type-update-by-change-event.html

+++ b/LayoutTests/fast/forms/number/number-type-update-by-change-event.html

@@ -3,6 +3,7 @@

<body>

+<input type="number" id="num1" onchange="handleMouseChange(this);">

function sendKey(keyName) {

var event = document.createEvent('KeyboardEvent');

@@ -15,13 +16,32 @@ function handleChange(element) {

++changeEventCounter;

}

+function handleMouseChange(element){

+ ++changeEventCounter;

var changeEventCounter = 0;

+function testMouseChangeEvent(){

tkent 2014/01/16 06:05:19 Please do not modify this test. This test is for

Habib Virji 2014/01/16 09:49:18 Is adding a new test file for the purpose okay? As

+ var numberInput1= document.getElementById('num1');

+ numberInput1.focus();

+ eventSender.mouseMoveTo(0, 0);

+ eventSender.mouseMoveTo(numberInput1.offsetLeft + numberInput1.offsetWidth - 10, numberInput1.offsetTop + numberInput1.offsetHeight / 4);

+ eventSender.mouseDown();

tkent 2014/01/16 06:05:19 Why two mouseDown()s?

Habib Virji 2014/01/16 09:49:18 Wanted to show that multiple mouseDown does not tr

+ shouldBe('changeEventCounter', '1');

tkent 2014/01/16 06:05:19 We should press the mouse button for a while, and

Habib Virji 2014/01/16 09:49:18 Was not sure how to simulate press mouse button, t

+ eventSender.mouseUp();

+ shouldBe('changeEventCounter', '2');

var numberInput = document.getElementsByTagName('input')[0];

numberInput.focus();

sendKey('Up');

+numberInput.blur();

testPassed('if not crashed in ASAN build.');

shouldBe('changeEventCounter', '1');

+testMouseChangeEvent();

</script>

</body>

</html>