LayoutTests/fast/forms/number/number-type-update-by-change-event.html - Issue 128133002: Update of change event for input type number

Side by Side Diff: LayoutTests/fast/forms/number/number-type-update-by-change-event.html

Issue 128133002: Update of change event for input type number (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review updates Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE>	1 <!DOCTYPE>

2 <html>	2 <html>

3 <body>	3 <body>

4 <script src="../../../resources/js-test.js"></script>	4 <script src="../../../resources/js-test.js"></script>

5 <input type="number" onchange="handleChange(this);">	5 <input type="number" onchange="handleChange(this);">

	6 <input type="number" id="num1" onchange="handleMouseChange(this);">

6 <script>	7 <script>

7 function sendKey(keyName) {	8 function sendKey(keyName) {

8 var event = document.createEvent('KeyboardEvent');	9 var event = document.createEvent('KeyboardEvent');

9 event.initKeyboardEvent('keydown', true, true, document.defaultView, keyName );	10 event.initKeyboardEvent('keydown', true, true, document.defaultView, keyName );

10 document.activeElement.dispatchEvent(event);	11 document.activeElement.dispatchEvent(event);

11 }	12 }

12	13

13 function handleChange(element) {	14 function handleChange(element) {

14 element.type = '';	15 element.type = '';

15 ++changeEventCounter;	16 ++changeEventCounter;

16 }	17 }

17	18

	19 function handleMouseChange(element){

	20 ++changeEventCounter;

	21 }

	22

18 var changeEventCounter = 0;	23 var changeEventCounter = 0;

	24 function testMouseChangeEvent(){
	tkent 2014/01/16 06:05:19 Please do not modify this test. This test is for Please do not modify this test. This test is for 'type-update-by-change-event', and we shouldn't add other purposes. Habib Virji 2014/01/16 09:49:18 Is adding a new test file for the purpose okay? As Show quoted text On 2014/01/16 06:05:19, tkent wrote: > Please do not modify this test. This test is for 'type-update-by-change-event', > and we shouldn't add other purposes. Is adding a new test file for the purpose okay? As in CL 128153002, I have updated a common-spinbutton-change-and-input-events.js, to check input and change event trigger.
	25 var numberInput1= document.getElementById('num1');

	26 numberInput1.focus();

	27 eventSender.mouseMoveTo(0, 0);

	28 eventSender.mouseMoveTo(numberInput1.offsetLeft + numberInput1.offsetWid th - 10, numberInput1.offsetTop + numberInput1.offsetHeight / 4);

	29 eventSender.mouseDown();

	30 eventSender.mouseDown();
	tkent 2014/01/16 06:05:19 Why two mouseDown()s? Why two mouseDown()s? Habib Virji 2014/01/16 09:49:18 Wanted to show that multiple mouseDown does not tr Show quoted text On 2014/01/16 06:05:19, tkent wrote: > Why two mouseDown()s? Wanted to show that multiple mouseDown does not trigger change event. It is triggered only when mouseUp is called.
	31 shouldBe('changeEventCounter', '1');
	tkent 2014/01/16 06:05:19 We should press the mouse button for a while, and We should press the mouse button for a while, and confirm 'input' events are dispatched and no 'change' events are dispatched. Habib Virji 2014/01/16 09:49:18 Was not sure how to simulate press mouse button, t Show quoted text On 2014/01/16 06:05:19, tkent wrote: > We should press the mouse button for a while, and confirm 'input' events are > dispatched and no 'change' events are dispatched. Was not sure how to simulate press mouse button, that's why implemented above 2 mouseDown.
	32 eventSender.mouseUp();

	33 shouldBe('changeEventCounter', '2');

	34 }

	35

19 var numberInput = document.getElementsByTagName('input')[0];	36 var numberInput = document.getElementsByTagName('input')[0];

20 numberInput.focus();	37 numberInput.focus();

21 sendKey('Up');	38 sendKey('Up');

	39 numberInput.blur();

22	40

23 testPassed('if not crashed in ASAN build.');	41 testPassed('if not crashed in ASAN build.');

24 shouldBe('changeEventCounter', '1');	42 shouldBe('changeEventCounter', '1');

	43 testMouseChangeEvent();

	44

25 </script>	45 </script>

26 </body>	46 </body>

27 </html>	47 </html>

OLD	NEW