Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: extensions/common/manifest_handlers/shared_module_info.cc

Issue 1281313003: base: Remove using:: declaration from version.h header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ninja -C out/Debug all Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handlers/shared_module_info.cc
diff --git a/extensions/common/manifest_handlers/shared_module_info.cc b/extensions/common/manifest_handlers/shared_module_info.cc
index 99efe8828fdc9fa1c7be4aacac5ee8c1dbbce662..edac89199603c6117e1e61de79c12d4ad01afa22 100644
--- a/extensions/common/manifest_handlers/shared_module_info.cc
+++ b/extensions/common/manifest_handlers/shared_module_info.cc
@@ -183,7 +183,7 @@ bool SharedModuleInfo::Parse(const Extension* extension,
return false;
}
imports_.back().minimum_version = min_version;
- Version v(min_version);
+ base::Version v(min_version);
if (!v.IsValid()) {
*error = ErrorUtils::FormatErrorMessageUTF16(
errors::kInvalidImportVersion, base::IntToString(i));

Powered by Google App Engine
This is Rietveld 408576698