Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1281303002: QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in (Closed)

Created:
5 years, 4 months ago by ramant (doing other things)
Modified:
5 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in QuicSentPacketManager::MaybeRetransmitTailLossProbe. BUG=517726 R=rch@chromium.org Committed: https://crrev.com/22f7d9ae62bb4867579032e3cae46dbb5720a8ff Cr-Commit-Position: refs/heads/master@{#342694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M net/quic/quic_sent_packet_manager.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1244073002 Patch 1

Messages

Total messages: 7 (1 generated)
ramant (doing other things)
5 years, 4 months ago (2015-08-10 17:49:56 UTC) #1
Ryan Hamilton
lgtm
5 years, 4 months ago (2015-08-10 19:18:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281303002/1
5 years, 4 months ago (2015-08-10 19:42:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 21:02:15 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22f7d9ae62bb4867579032e3cae46dbb5720a8ff Cr-Commit-Position: refs/heads/master@{#342694}
5 years, 4 months ago (2015-08-10 21:03:00 UTC) #6
ramant (doing other things)
5 years, 4 months ago (2015-08-13 17:42:52 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1287363002/ by rtenneti@chromium.org.

The reason for reverting is: BUG=520301.

Powered by Google App Engine
This is Rietveld 408576698