Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: extensions/browser/api/webcam_private/webcam.h

Issue 1281263003: Change webcamPrivate.set/get/reset to async APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Zach's comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/webcam_private/webcam.h
diff --git a/extensions/browser/api/webcam_private/webcam.h b/extensions/browser/api/webcam_private/webcam.h
index 86cadd69f38271030adb0b0978b22934860bf9ac..406f0c3329a9b7d9471282ff631a339cf7620127 100644
--- a/extensions/browser/api/webcam_private/webcam.h
+++ b/extensions/browser/api/webcam_private/webcam.h
@@ -31,15 +31,23 @@ class Webcam : public base::RefCounted<Webcam> {
Webcam();
- virtual void Reset(bool pan, bool tilt, bool zoom) = 0;
- virtual bool GetPan(int* value) = 0;
- virtual bool GetTilt(int* value) = 0;
- virtual bool GetZoom(int* value) = 0;
- virtual bool SetPan(int value) = 0;
- virtual bool SetTilt(int value) = 0;
- virtual bool SetZoom(int value) = 0;
- virtual bool SetPanDirection(PanDirection direction) = 0;
- virtual bool SetTiltDirection(TiltDirection direction) = 0;
+ using GetPTZCompleteCallback = base::Callback<void(bool, int)>;
+ using SetPTZCompleteCallback = base::Callback<void(bool)>;
+
+ virtual void GetPan(const GetPTZCompleteCallback& callback) = 0;
+ virtual void GetTilt(const GetPTZCompleteCallback& callback) = 0;
+ virtual void GetZoom(const GetPTZCompleteCallback& callback) = 0;
+ virtual void SetPan(int value, const SetPTZCompleteCallback& callback) = 0;
+ virtual void SetTilt(int value, const SetPTZCompleteCallback& callback) = 0;
+ virtual void SetZoom(int value, const SetPTZCompleteCallback& callback) = 0;
+ virtual void SetPanDirection(PanDirection direction,
+ const SetPTZCompleteCallback& callback) = 0;
+ virtual void SetTiltDirection(TiltDirection direction,
+ const SetPTZCompleteCallback& callback) = 0;
+ virtual void Reset(bool pan,
+ bool tilt,
+ bool zoom,
+ const SetPTZCompleteCallback& callback) = 0;
protected:
friend class base::RefCounted<Webcam>;
« no previous file with comments | « extensions/browser/api/webcam_private/visca_webcam.cc ('k') | extensions/browser/api/webcam_private/webcam_private_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698