Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: extensions/browser/api/webcam_private/webcam.h

Issue 1281263003: Change webcamPrivate.set/get/reset to async APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Zach's comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_API_WEBCAM_PRIVATE_WEBCAM_H_ 5 #ifndef EXTENSIONS_BROWSER_API_WEBCAM_PRIVATE_WEBCAM_H_
6 #define EXTENSIONS_BROWSER_API_WEBCAM_PRIVATE_WEBCAM_H_ 6 #define EXTENSIONS_BROWSER_API_WEBCAM_PRIVATE_WEBCAM_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 13 matching lines...) Expand all
24 }; 24 };
25 25
26 enum TiltDirection { 26 enum TiltDirection {
27 TILT_UP, 27 TILT_UP,
28 TILT_DOWN, 28 TILT_DOWN,
29 TILT_STOP, 29 TILT_STOP,
30 }; 30 };
31 31
32 Webcam(); 32 Webcam();
33 33
34 virtual void Reset(bool pan, bool tilt, bool zoom) = 0; 34 using GetPTZCompleteCallback = base::Callback<void(bool, int)>;
35 virtual bool GetPan(int* value) = 0; 35 using SetPTZCompleteCallback = base::Callback<void(bool)>;
36 virtual bool GetTilt(int* value) = 0; 36
37 virtual bool GetZoom(int* value) = 0; 37 virtual void GetPan(const GetPTZCompleteCallback& callback) = 0;
38 virtual bool SetPan(int value) = 0; 38 virtual void GetTilt(const GetPTZCompleteCallback& callback) = 0;
39 virtual bool SetTilt(int value) = 0; 39 virtual void GetZoom(const GetPTZCompleteCallback& callback) = 0;
40 virtual bool SetZoom(int value) = 0; 40 virtual void SetPan(int value, const SetPTZCompleteCallback& callback) = 0;
41 virtual bool SetPanDirection(PanDirection direction) = 0; 41 virtual void SetTilt(int value, const SetPTZCompleteCallback& callback) = 0;
42 virtual bool SetTiltDirection(TiltDirection direction) = 0; 42 virtual void SetZoom(int value, const SetPTZCompleteCallback& callback) = 0;
43 virtual void SetPanDirection(PanDirection direction,
44 const SetPTZCompleteCallback& callback) = 0;
45 virtual void SetTiltDirection(TiltDirection direction,
46 const SetPTZCompleteCallback& callback) = 0;
47 virtual void Reset(bool pan,
48 bool tilt,
49 bool zoom,
50 const SetPTZCompleteCallback& callback) = 0;
43 51
44 protected: 52 protected:
45 friend class base::RefCounted<Webcam>; 53 friend class base::RefCounted<Webcam>;
46 virtual ~Webcam(); 54 virtual ~Webcam();
47 55
48 private: 56 private:
49 DISALLOW_COPY_AND_ASSIGN(Webcam); 57 DISALLOW_COPY_AND_ASSIGN(Webcam);
50 }; 58 };
51 59
52 class WebcamResource : public ApiResource { 60 class WebcamResource : public ApiResource {
(...skipping 15 matching lines...) Expand all
68 private: 76 private:
69 scoped_refptr<Webcam> webcam_; 77 scoped_refptr<Webcam> webcam_;
70 std::string webcam_id_; 78 std::string webcam_id_;
71 79
72 DISALLOW_COPY_AND_ASSIGN(WebcamResource); 80 DISALLOW_COPY_AND_ASSIGN(WebcamResource);
73 }; 81 };
74 82
75 } // namespace extensions 83 } // namespace extensions
76 84
77 #endif // EXTENSIONS_BROWSER_API_WEBCAM_PRIVATE_WEBCAM_H_ 85 #endif // EXTENSIONS_BROWSER_API_WEBCAM_PRIVATE_WEBCAM_H_
OLDNEW
« no previous file with comments | « extensions/browser/api/webcam_private/visca_webcam.cc ('k') | extensions/browser/api/webcam_private/webcam_private_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698