Issue 128123002: gpu: Early return GpuCommandBufferStub::OnWaitSyncPoint() if the sync point is retired.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128123002: gpu: Early return GpuCommandBufferStub::OnWaitSyncPoint() if the sync point is retired. (Closed)

Created:
6 years, 11 months ago by dshwang

Modified:
6 years, 11 months ago

Reviewers:
Ken Russell (switch to Gerrit), piman

CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, darin-cc_chromium.org, danakj

Base URL:
https://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

gpu: Early return GpuCommandBufferStub::OnWaitSyncPoint() if the sync point is retired. If the sync point is retired, the scheduler already executed all gl calls before the sync point, so OnWaitSyncPoint() does not need to do anything. Currently, OnWaitSyncPoint() always sets the scheduler off and then on. This CL makes OnWaitSyncPoint() be able to return early. BUG=332401 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243932

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix nits #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
M	content/common/gpu/gpu_command_buffer_stub.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	content/common/gpu/sync_point_manager.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/common/gpu/sync_point_manager.cc	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

piman

lgtm https://codereview.chromium.org/128123002/diff/1/content/common/gpu/sync_point_manager.cc File content/common/gpu/sync_point_manager.cc (right): https://codereview.chromium.org/128123002/diff/1/content/common/gpu/sync_point_manager.cc#newcode65 content/common/gpu/sync_point_manager.cc:65: if (it != sync_point_map_.end()) nit: just return it ...

6 years, 11 months ago (2014-01-08 21:43:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/128123002/140001

6 years, 11 months ago (2014-01-09 16:22:50 UTC) #4

Message was sent while issue was closed.

Change committed as 243932

Expand Messages | Collapse Messages