- Introduce the notion of setter constraints in the type inferrer, where we record things like: fie…

- Introduce the notion of setter constraints in the type inferrer, where we record things like: field++, field += 42, field = other.field. Take these contraints into account when computing the type.
- Compute the LUB when iterating over selectors, and fix a bug in how we handle native elements.
Committed: https://code.google.com/p/dart/source/detail?r=20144

[kasperl, 2013-03-18 08:32:44]

LGTM. I think we should figure out how to generalize it a little bit to cover
more kinds of expressions, but that doesn't have to be now.

https://codereview.chromium.org/12811010/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/12811010/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:154:
* A map of constraints on a setter. Maps a [Node] node to the
I'd get rid of the [Node] part of the comments here.

[ngeoffray, 2013-03-18 08:43:29]

Thanks Kasper.

https://codereview.chromium.org/12811010/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/12811010/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:154:
* A map of constraints on a setter. Maps a [Node] node to the
On 2013/03/18 08:32:44, kasperl wrote:
> I'd get rid of the [Node] part of the comments here.

Done.

[ngeoffray, 2013-03-18 09:17:55]

Committed patchset #2 manually as r20144 (presubmit successful).