Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1280693003: Fix color swap for webp 565 (Closed)

Created:
5 years, 4 months ago by scroggo_chromium
Modified:
5 years, 4 months ago
Reviewers:
msarett, scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix color swap for webp 565 When webp decoding to 565, swap the colors so they look right. BUG=skia:4174 Committed: https://skia.googlesource.com/skia/+/9ce386a27ddcd7be5f4d322e65ef95f14180f640

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/libwebp_skia.gypi View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
scroggo_chromium
https://codereview.chromium.org/1280693003/diff/1/gyp/libwebp_skia.gypi File gyp/libwebp_skia.gypi (right): https://codereview.chromium.org/1280693003/diff/1/gyp/libwebp_skia.gypi#newcode15 gyp/libwebp_skia.gypi:15: 'WEBP_SWAP_16BIT_CSP', I'm not sure whether this should be defined ...
5 years, 4 months ago (2015-08-06 18:24:45 UTC) #2
msarett
Works for me. lgtm
5 years, 4 months ago (2015-08-06 18:28:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280693003/1
5 years, 4 months ago (2015-08-06 18:28:58 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 18:44:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9ce386a27ddcd7be5f4d322e65ef95f14180f640

Powered by Google App Engine
This is Rietveld 408576698