gyp/libwebp_skia.gypi - Issue 1280693003: Fix color swap for webp 565

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gyp/libwebp_skia.gypi

Issue 1280693003: Fix color swap for webp 565 (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2015 Google Inc.	1 # Copyright 2015 Google Inc.

2 #	2 #

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 # This allows us to build libwebp with a custom config.h file. It is currently	6 # This allows us to build libwebp with a custom config.h file. It is currently

7 # needed to work around skbug.com/4037, but perhaps we might have another need	7 # needed to work around skbug.com/4037, but perhaps we might have another need

8 # for it in the future.	8 # for it in the future.

9 {	9 {

10 'include_dirs': [	10 'include_dirs': [

11 '../third_party/libwebp/webp',	11 '../third_party/libwebp/webp',

12 ],	12 ],

13 'defines': [	13 'defines': [

14 'HAVE_CONFIG_H',	14 'HAVE_CONFIG_H',

	15 'WEBP_SWAP_16BIT_CSP',
	scroggo_chromium 2015/08/06 18:24:45 I'm not sure whether this should be defined for al I'm not sure whether this should be defined for all platforms. Looking in gold, it appears that we are drawing incorrectly on at least all platforms except for windows. (For some reason, I do not see any output from windows in 565.) I'd like to land this and then see if gold shows any problems with it.
15 ],	16 ],

16 }	17 }

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »