Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6191)

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Issue 1280673003: [Mac] Enable MacViews site settings bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enabledialogs
Patch Set: Address comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.h
diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
index 712f183bf1caae5ba633093441b8a5d08a95539b..1b931fd2acbfe3ab06047e37f8cc32b5b6692d71 100644
--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
@@ -41,13 +41,19 @@ class WebsiteSettingsPopupView
public views::TabbedPaneListener,
public WebsiteSettingsUI {
public:
+ // To make the bubble's arrow point directly at the location icon rather than
+ // at the Omnibox's edge, the bubble's anchor rect will be insetted by this
tapted 2015/08/11 03:20:38 nit: insetted -> inset is right I think. But I th
jackhou1 2015/08/11 03:54:02 Done.
+ // amount of pixels.
+ static const int kLocationIconVerticalMargin;
+
~WebsiteSettingsPopupView() override;
- static void ShowPopup(views::View* anchor_view,
- Profile* profile,
- content::WebContents* web_contents,
- const GURL& url,
- const content::SSLStatus& ssl);
+ static views::BubbleDelegateView* ShowPopup(
+ views::View* anchor_view,
+ Profile* profile,
+ content::WebContents* web_contents,
+ const GURL& url,
+ const content::SSLStatus& ssl);
static bool IsPopupShowing();

Powered by Google App Engine
This is Rietveld 408576698