Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Issue 1280673003: [Mac] Enable MacViews site settings bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enabledialogs
Patch Set: Address comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_WEBSITE_SETTINGS_POPUP_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_WEBSITE_SETTINGS_POPUP_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_WEBSITE_SETTINGS_POPUP_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_WEBSITE_SETTINGS_POPUP_VIEW_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 23 matching lines...) Expand all
34 34
35 // The views implementation of the website settings UI. 35 // The views implementation of the website settings UI.
36 class WebsiteSettingsPopupView 36 class WebsiteSettingsPopupView
37 : public PermissionSelectorViewObserver, 37 : public PermissionSelectorViewObserver,
38 public views::BubbleDelegateView, 38 public views::BubbleDelegateView,
39 public views::ButtonListener, 39 public views::ButtonListener,
40 public views::LinkListener, 40 public views::LinkListener,
41 public views::TabbedPaneListener, 41 public views::TabbedPaneListener,
42 public WebsiteSettingsUI { 42 public WebsiteSettingsUI {
43 public: 43 public:
44 // To make the bubble's arrow point directly at the location icon rather than
45 // at the Omnibox's edge, the bubble's anchor rect will be insetted by this
tapted 2015/08/11 03:20:38 nit: insetted -> inset is right I think. But I th
jackhou1 2015/08/11 03:54:02 Done.
46 // amount of pixels.
47 static const int kLocationIconVerticalMargin;
48
44 ~WebsiteSettingsPopupView() override; 49 ~WebsiteSettingsPopupView() override;
45 50
46 static void ShowPopup(views::View* anchor_view, 51 static views::BubbleDelegateView* ShowPopup(
47 Profile* profile, 52 views::View* anchor_view,
48 content::WebContents* web_contents, 53 Profile* profile,
49 const GURL& url, 54 content::WebContents* web_contents,
50 const content::SSLStatus& ssl); 55 const GURL& url,
56 const content::SSLStatus& ssl);
51 57
52 static bool IsPopupShowing(); 58 static bool IsPopupShowing();
53 59
54 private: 60 private:
55 WebsiteSettingsPopupView(views::View* anchor_view, 61 WebsiteSettingsPopupView(views::View* anchor_view,
56 Profile* profile, 62 Profile* profile,
57 content::WebContents* web_contents, 63 content::WebContents* web_contents,
58 const GURL& url, 64 const GURL& url,
59 const content::SSLStatus& ssl); 65 const content::SSLStatus& ssl);
60 66
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 views::Link* site_settings_link_; 176 views::Link* site_settings_link_;
171 177
172 views::View* connection_info_content_; 178 views::View* connection_info_content_;
173 179
174 base::WeakPtrFactory<WebsiteSettingsPopupView> weak_factory_; 180 base::WeakPtrFactory<WebsiteSettingsPopupView> weak_factory_;
175 181
176 DISALLOW_COPY_AND_ASSIGN(WebsiteSettingsPopupView); 182 DISALLOW_COPY_AND_ASSIGN(WebsiteSettingsPopupView);
177 }; 183 };
178 184
179 #endif // CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_WEBSITE_SETTINGS_POPUP_VIEW_ H_ 185 #endif // CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_WEBSITE_SETTINGS_POPUP_VIEW_ H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698