chrome/browser/ui/views/website_settings/website_settings_popup_view.h - Issue 1280673003: [Mac] Enable MacViews site settings bubble behind --enable-mac-views-dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Issue 1280673003: [Mac] Enable MacViews site settings bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enabledialogs

Patch Set: Address comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

index 712f183bf1caae5ba633093441b8a5d08a95539b..a74f032be14981ba059ebdba61cb92c4603c1c7b 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

@@ -43,7 +43,9 @@ class WebsiteSettingsPopupView

public:

~WebsiteSettingsPopupView() override;

+ // If |anchor_view| is null, |anchor_rect| is used to anchor the bubble.

static void ShowPopup(views::View* anchor_view,

+ const gfx::Rect& anchor_rect,

Profile* profile,

content::WebContents* web_contents,

const GURL& url,

@@ -53,6 +55,7 @@ class WebsiteSettingsPopupView

private:

WebsiteSettingsPopupView(views::View* anchor_view,

+ gfx::NativeView parent_window,

Profile* profile,

content::WebContents* web_contents,

const GURL& url,