chrome/browser/ui/views/frame/browser_view.cc - Issue 1280673003: [Mac] Enable MacViews site settings bubble behind --enable-mac-views-dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1280673003: [Mac] Enable MacViews site settings bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enabledialogs

Patch Set: Address comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/browser_dialogs_views_mac.cc ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 2449b69003ea3295d62480d00d5bf02890dbf011..71ce19c8fdd4bbd02e2fb58bb8a9ebcb812f3cd0 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1368,8 +1368,8 @@ void BrowserView::ShowWebsiteSettings(Profile* profile,

if (!popup_anchor)

popup_anchor = GetLocationBarView()->location_icon_view();

- WebsiteSettingsPopupView::ShowPopup(popup_anchor, profile, web_contents, url,

- ssl);

+ WebsiteSettingsPopupView::ShowPopup(popup_anchor, gfx::Rect(), profile,

+ web_contents, url, ssl);

}

void BrowserView::ShowAppMenu() {