Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1280543002: Avoid temporary Range object creation in SpellChecker::replaceMisspelledRange() (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent, yoichio, hajimehoshi
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid temporary Range object creation in SpellChecker::replaceMisspelledRange() This patch changes |SpellChecker::replaceMisspelledRange()| to use |EphemralRange| instead of |Range| object to avoid registering temporary |Range| object for updating on |Document| for Oilpan. BUG=388681 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200100

Patch Set 1 : 2015-08-06T16:32:55 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/editing/SpellChecker.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-06 07:59:05 UTC) #2
yoichio
lgtm
5 years, 4 months ago (2015-08-06 08:08:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280543002/1
5 years, 4 months ago (2015-08-06 08:18:44 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 08:37:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200100

Powered by Google App Engine
This is Rietveld 408576698