Avoid temporary Range object creation in SpellChecker::replaceMisspelledRange()

Source/core/editing/SpellChecker.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 741 matching lines @@
 }
 
 void SpellChecker::replaceMisspelledRange(const String& text)
 {
     EphemeralRange caretRange = frame().selection().selection().toNormalizedEphemeralRange();
     if (caretRange.isNull())
         return;
     DocumentMarkerVector markers = frame().document()->markers().markersInRange(caretRange, DocumentMarker::MisspellingMarkers());
     if (markers.size() < 1 || markers[0]->startOffset() >= markers[0]->endOffset())
         return;
-    // TODO(yosin) |markerRange| should be |EphemeralRange|.
-    RefPtrWillBeRawPtr<Range> markerRange = Range::create(caretRange.document(), caretRange.startPosition().computeContainerNode(), markers[0]->startOffset(), caretRange.endPosition().computeContainerNode(), markers[0]->endOffset());
-    if (!markerRange)
+    EphemeralRange markerRange = EphemeralRange(Position(caretRange.startPosition().computeContainerNode(), markers[0]->startOffset()), Position(caretRange.endPosition().computeContainerNode(), markers[0]->endOffset()));
+    if (markerRange.isNull())
         return;
-    frame().selection().setSelection(VisibleSelection(markerRange.get()), CharacterGranularity);
+    frame().selection().setSelection(VisibleSelection(markerRange), CharacterGranularity);
     frame().editor().replaceSelectionWithText(text, false, false);
 }
 
 void SpellChecker::respondToChangedSelection(const VisibleSelection& oldSelection, FrameSelection::SetSelectionOptions options)
 {
     bool closeTyping = options & FrameSelection::CloseTyping;
     bool isContinuousSpellCheckingEnabled = this->isContinuousSpellCheckingEnabled();
     bool isContinuousGrammarCheckingEnabled = isContinuousSpellCheckingEnabled && isGrammarCheckingEnabled();
     if (isContinuousSpellCheckingEnabled) {
         VisibleSelection newAdjacentWords;
@@ skipping 166 matching lines @@
     m_spellCheckRequester->requestCheckingFor(SpellCheckRequest::create(TextCheckingTypeSpelling | TextCheckingTypeGrammar, TextCheckingProcessBatch, rangeToCheck, rangeToCheck));
 }
 
 DEFINE_TRACE(SpellChecker)
 {
     visitor->trace(m_frame);
     visitor->trace(m_spellCheckRequester);
 }
 
 } // namespace blink